PKGDIR ambiguous (was: cvs commit: src/usr.sbin/pkg_install/info info.h main.c perform.c pkg_info.1 src/usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/lib lib.h url.c)

[Florent Thoumie]

On Mon, 2006-08-21 at 08:09 +0200, Raphael H. Becker wrote:
> Hi Florent,
> 
> PKGDIR is ambiguous in the context of ports and packages.
> 
> I set PKGDIR=/some/where/my/pkg in my /etc/profile which causes the
> ports to fail badly creating any packages:
> 
> It is used in ports/Mk/bsd.port.mk:
> # PKGDIR                - A directory containing any package creation
> # files.
> #                                 Default: ${MASTERDIR}
> [...]
> PKGDIR?=                ${MASTERDIR}
> 
> Havin set PKGDIR statically is a very bad idea here.

Agreed, the name isn't really well-suited. I seem to recall I've been
advised to use that name because it had the same meaning in ports. I'm
not really sure about that anymore. PKG_CACHEDIR would probably be
better.

> PS: I've googled around^W^Wused Google to search the web but it seems
> there was no bugreport about this? Bug or feature?

Not everything happen via PR.

-- 
Florent Thoumie
flz at FreeBSD.org
FreeBSD Committer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20060821/0fce949c/attachment.pgp