PKGDIR ambiguous (was: cvs commit: src/usr.sbin/pkg_install/info info.h main.c perform.c pkg_info.1 src/usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/lib lib.h url.c)

[Raphael H. Becker]

Hi Florent,

PKGDIR is ambiguous in the context of ports and packages.

I set PKGDIR=/some/where/my/pkg in my /etc/profile which causes the
ports to fail badly creating any packages:

It is used in ports/Mk/bsd.port.mk:
# PKGDIR                - A directory containing any package creation
# files.
#                                 Default: ${MASTERDIR}
[...]
PKGDIR?=                ${MASTERDIR}

Havin set PKGDIR statically is a very bad idea here.


Regards
Raphael Becker

PS: I've googled around^W^Wused Google to search the web but it seems
there was no bugreport about this? Bug or feature?

On Mon, Jan 16, 2006 at 07:51:41PM +0000, Florent Thoumie wrote:
> flz         2006-01-16 19:51:41 UTC
> 
>   FreeBSD src repository (ports committer)
> 
>   Modified files:        (Branch: RELENG_5)
>     usr.sbin/pkg_install/info perform.c pkg_info.1 info.h main.c 
>     usr.sbin/pkg_install/add main.c add.h pkg_add.1 perform.c 
>     usr.sbin/pkg_install/lib lib.h url.c 
>   Log:
>   MFC:
>   
>     Add -K option to pkg_add and pkg_info.
>     This option saves packages to PKGDIR (if defined or current directory by default)
>     as they are downloaded.
>     Silent a warning when -n is used and package has a +DISPLAY file.
>   
>         src/usr.sbin/pkg_install/info/perform.c: rev 1.53 -> 1.54
>         src/usr.sbin/pkg_install/add/main.c: rev 1.65 -> 1.66
>         src/usr.sbin/pkg_install/lib/lib.h: rev 1.56 -> 1.57
>         src/usr.sbin/pkg_install/info/pkg_info.1: rev 1.55 -> 1.56
>         src/usr.sbin/pkg_install/add/add.h: rev 1.12 -> 1.13
>         src/usr.sbin/pkg_install/add/pkg_add.1: rev 1.68 -> 1.69
>         src/usr.sbin/pkg_install/add/perform.c: rev 1.78 -> 1.79
>         src/usr.sbin/pkg_install/info/info.h: rev 1.28 -> 1.29
>         src/usr.sbin/pkg_install/lib/url.c: rev 1.4 -> 1.5
>         src/usr.sbin/pkg_install/info/main.c: rev 1.48 -> 1.49
>   
>   Revision  Changes    Path
>   1.11.2.2  +1 -0      src/usr.sbin/pkg_install/add/add.h
>   1.59.2.6  +7 -3      src/usr.sbin/pkg_install/add/main.c
>   1.77.2.2  +7 -4      src/usr.sbin/pkg_install/add/perform.c
>   1.65.2.2  +12 -2     src/usr.sbin/pkg_install/add/pkg_add.1
>   1.27.2.1  +1 -0      src/usr.sbin/pkg_install/info/info.h
>   1.46.2.2  +7 -2      src/usr.sbin/pkg_install/info/main.c
>   1.53.2.1  +1 -1      src/usr.sbin/pkg_install/info/perform.c
>   1.53.2.2  +8 -2      src/usr.sbin/pkg_install/info/pkg_info.1
>   1.53.2.1  +1 -1      src/usr.sbin/pkg_install/lib/lib.h
>   1.4.4.1   +26 -3     src/usr.sbin/pkg_install/lib/url.c
> _______________________________________________
> cvs-all at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/cvs-all
> To unsubscribe, send any mail to "cvs-all-unsubscribe at freebsd.org"

-- 
Mfg
Raphael Becker
-- 
PHOENIX Pharmahandel
Aktiengesellschaft & Co KG
Marketing Services

Tel: 0621 / 8505-536
Fax: 0621 / 8505-462
E-Mail: R.H.Becker at phoenix-ag.de