PKGDIR ambiguous (was: cvs commit: src/usr.sbin/pkg_install/info info.h main.c perform.c pkg_info.1 src/usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/lib lib.h url.c)

[Kris Kennaway]

On Mon, Aug 21, 2006 at 08:09:45AM +0200, Raphael H. Becker wrote:
> 
> Hi Florent,
> 
> PKGDIR is ambiguous in the context of ports and packages.
> 
> I set PKGDIR=/some/where/my/pkg in my /etc/profile which causes the
> ports to fail badly creating any packages:
> 
> It is used in ports/Mk/bsd.port.mk:
> # PKGDIR                - A directory containing any package creation
> # files.
> #                                 Default: ${MASTERDIR}
> [...]
> PKGDIR?=                ${MASTERDIR}
> 
> Havin set PKGDIR statically is a very bad idea here.

Yes, PKGDIR is incorrect in this usage.  The documented place where
packages are stored is:

# PACKAGES              - A top level directory where all packages go (rather than
#                                 going locally to each port).
#                                 Default: ${PORTSDIR}/packages
#

> > flz         2006-01-16 19:51:41 UTC
> > 
> >   FreeBSD src repository (ports committer)
> > 
> >   Modified files:        (Branch: RELENG_5)
> >     usr.sbin/pkg_install/info perform.c pkg_info.1 info.h main.c 
> >     usr.sbin/pkg_install/add main.c add.h pkg_add.1 perform.c 
> >     usr.sbin/pkg_install/lib lib.h url.c 
> >   Log:
> >   MFC:
> >   
> >     Add -K option to pkg_add and pkg_info.
> >     This option saves packages to PKGDIR (if defined or current directory by default)
> >     as they are downloaded.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20060821/5f00a30f/attachment.pgp