Re: git: 8ea6c1154094 - main - usr.bin/bc: remove OpenBSD derived bc and dc commands
- In reply to: Stefan_Eßer : "Re: git: 8ea6c1154094 - main - usr.bin/bc: remove OpenBSD derived bc and dc commands"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 26 Nov 2024 06:54:58 UTC
Stefan Eßer <se@FreeBSD.org> writes: > Dag-Erling Smørgrav <des@FreeBSD.org> writes: >> I appreciate your efforts but this is incomplete, as was pointed out >> in review. > I was not aware that the review was incomplete What did you think the red circle next to my name in Phabricator meant? > Are there any outstanding issues you know about? Yes. For instance, `tools/build/options/WITH_GH_BC` is still present. I pointed this out in Phabricator and marked the review as “changes requested” on October 2nd, despite your claim in your commit message that I had approved it. DES -- Dag-Erling Smørgrav - des@FreeBSD.org