From nobody Tue Nov 26 06:54:58 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XyCxc3pwkz5f0lG; Tue, 26 Nov 2024 06:55:00 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XyCxc2pByz4TdJ; Tue, 26 Nov 2024 06:55:00 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732604100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hugf5n4i5JZk5nRuQGSlfRSXkz3GxaTPyMiy32IlWpk=; b=AQBcG3pthfIuzOOB5U5zItcbhw8jtuOIVtCZ3UDHhjGGSOAoLnH/qbM9OvXgpNadi21Wl7 StvqbzcyBj87YhB/1ISMMaTAdkuNddBIERqBiHNxM6CM36z7yBURnqI3VaF7pOo1nKJx4p 86HxHh2ERxx3QmI3Ub1SKYrKDv2KmPfMiG9MkqQmX9uw5c6AHg17KodFsw7vZv4lb7pwLM 6lU4q6fqGNbljHPcd3hxQ+O6aS26utk0CD61Vuap3DZhT+JyEx+50t0NQqs0KF/Phe1lv+ 2a2ohjzpCQMvOWoml5TWxhAGazza3lkycaU4sFncE4bDvnDo7cQRSchQLPnnOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732604100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hugf5n4i5JZk5nRuQGSlfRSXkz3GxaTPyMiy32IlWpk=; b=qktxId2742tFaSsjQacnyBelTd5SjMVSgJRT9Qcq0ft207Nvr+8zWim+bkqrLzvYfuTBjK FI2KST6wVmbXubq66K6oAkdgfJ74fObn16yYOfpAJm7cuaiQMN+irOZL7jmFKIxFqRjiCP K99kHR+a63hR+PGjkHkMFWn05N+MEnReD+3su/FNyGb9n/ZEO/ZUA3aZVENo+2aaD1bSS+ gkq/DlDeAREyoT5ULG6cpYVNN6NK3NN9KNmMUbDzH2T60v3M+yE8XmzrRKLOUjLThxvwQN /IRsZwR15ZIXKu7jXwrbfBGgc/PXJ5JpHxbj3aRzFHJKqYIML0265e+hue+Paw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732604100; a=rsa-sha256; cv=none; b=S33hp9FZMhkP8SjZTu/8Oe6vdN9MR7qkPs/nt8/G91ZvO7fb42tfjWSosLSnxCMyaQPOM6 QJVM6RVq8TR9BnwMeOhfYXaJdxGAR6HH3VBD22AMEPaNn68P1/D2PXdVyPlbftccJHhR1J lWTTr+72TiHsrdJ3TC1o1pvbmE8Rx0rwP17koQL8ujiebrx8dOBnADRKXCYSFND4q8brcv uQKaYg+0SILgyaFNOv/2fPhWbvOwpt0zOp5a5wO0O5tGNw8rZLyZ/4KfAC/jH7v5uSuG8P qGy5SEVHOl2g797EExpuruspsWFZQEkDylz8HKNRYJMZfXe1rNMJgHV/udxwVA== Received: from ltc.des.dev (88-177-82-251.subs.proxad.net [88.177.82.251]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XyCxc1j7kzYmW; Tue, 26 Nov 2024 06:55:00 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id C32BB60686; Tue, 26 Nov 2024 07:54:58 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Stefan =?utf-8?Q?E=C3=9Fer?= Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 8ea6c1154094 - main - usr.bin/bc: remove OpenBSD derived bc and dc commands In-Reply-To: <4808a71f-a12b-4e70-ad51-a7979f5dff08@FreeBSD.org> ("Stefan =?utf-8?Q?E=C3=9Fer=22's?= message of "Mon, 25 Nov 2024 23:22:22 +0100") References: <202411242208.4AOM8WSe033669@gitrepo.freebsd.org> <86r06zcnb7.fsf@ltc.des.dev> <4808a71f-a12b-4e70-ad51-a7979f5dff08@FreeBSD.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Tue, 26 Nov 2024 07:54:58 +0100 Message-ID: <867c8qcwn1.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan E=C3=9Fer writes: > Dag-Erling Sm=C3=B8rgrav writes: >> I appreciate your efforts but this is incomplete, as was pointed out >> in review. > I was not aware that the review was incomplete What did you think the red circle next to my name in Phabricator meant? > Are there any outstanding issues you know about? Yes. For instance, `tools/build/options/WITH_GH_BC` is still present. I pointed this out in Phabricator and marked the review as =E2=80=9Cchanges requested=E2=80=9D on October 2nd, despite your claim in your commit message that I had approved it. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org