Re: git: 8ea6c1154094 - main - usr.bin/bc: remove OpenBSD derived bc and dc commands
Date: Mon, 25 Nov 2024 22:22:22 UTC
Am 25.11.24 um 17:04 schrieb Dag-Erling Smørgrav: > Stefan Eßer <se@FreeBSD.org> writes: >> The branch main has been updated by se: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=8ea6c115409450ff58a8c6b5e818319d181c6bff >> >> commit 8ea6c115409450ff58a8c6b5e818319d181c6bff >> Author: Stefan Eßer <se@FreeBSD.org> >> AuthorDate: 2024-11-24 21:38:23 +0000 >> Commit: Stefan Eßer <se@FreeBSD.org> >> CommitDate: 2024-11-24 21:38:23 +0000 >> >> usr.bin/bc: remove OpenBSD derived bc and dc commands >> >> In 2020, an improved implementation of the bc and dc commands >> developed by Gavin D. Howard has been imported into FreeBSD. >> It has replaced the OpenBSD-derived versions of these commands >> in all currently supported FreeBSD releases. >> >> The OpenBSD versions could still be built using the WITHOUT_GH_BC >> option. There have been no reports of problems or unexpected >> deviations from the OpenBSD version for some time, therefore >> keeping the OpenBSD version is no longer required in FreeBSD. >> >> This commit removes the option to build the OpenBSD version and >> corresponding source files from -CURRENT. No MFC is planned, all >> currently released FreeBSD versions should retain the build option. >> >> The WITHOUT_GH_BC option is no longer accepted and will cause >> make buildworld to fail. >> >> Reviewed by: des, emaste >> Approved by: des >> Relnotes: yes >> Differential Revision: https://reviews.freebsd.org/D46876 > > I appreciate your efforts but this is incomplete, as was pointed out in > review. I was not aware that the review was incomplete (but have learned about the missing removal of tests/usr.bin/dc, meanwhile). The diffs where not all with full context, but this did only affect files like ObsoleteFiles.inc, which had to be regenerated with an updated date for the commit of these changes, anyway. Are there any outstanding issues you know about? Regards, STefan