Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning
Date: Tue, 16 Aug 2022 12:54:57 UTC
On Tue, Aug 16, 2022 at 5:48 AM Alexey Dokuchaev <danfe@freebsd.org> wrote: > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > > ... > > But I think it is better to have the definitions matching the > > declarations exactly. We should sweep through the whole tree and get > > rid of all K&R functions too. I believe Warner wanted to attempt that. > > I won't comment on the technical side of things, but seeing this plethora > of identical commits is not just annoying, but pessimizes blaming as well. > Why can't it all be done in more coarse pieces, if not one commit? > I actually like it and don't see how it pessimizes blame. We have to do the changes, and it's better that we be able to back out or merge them one at a time. It's a huge pain to have to cherry pick a huge commit because of divergence in the target branch. Please do not take this suggestion to heart. Warner