Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning
- Reply: Dimitry Andric : "Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning"
- Reply: Warner Losh : "Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning"
- Reply: Cy Schubert : "Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning"
- In reply to: Dimitry Andric : "Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 16 Aug 2022 11:47:59 UTC
On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > ... > But I think it is better to have the definitions matching the > declarations exactly. We should sweep through the whole tree and get > rid of all K&R functions too. I believe Warner wanted to attempt that. I won't comment on the technical side of things, but seeing this plethora of identical commits is not just annoying, but pessimizes blaming as well. Why can't it all be done in more coarse pieces, if not one commit? ./danfe