From nobody Tue Aug 16 12:54:57 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M6WMd6vTBz4Z2sC for ; Tue, 16 Aug 2022 12:55:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M6WMd2DJ1z4M6R for ; Tue, 16 Aug 2022 12:55:09 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x92d.google.com with SMTP id f15so3970140uao.12 for ; Tue, 16 Aug 2022 05:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=GObavgV+Z4fgQXJ9pSIPixfXgFzveZNYSHXO7GYmt8Y=; b=D96bBg1puct8tmBs0hm8OPrdQz/jjg0SCR6NX/FeULADFceUzDluu5rI+sKhD4f3Sj WB4wBWjtyhay7E8Ji7ZGe+aBZslIEdylH3YAtf2sngqFIaciBr1WvqTnOc98cYK+XZbD Jllu3r0HLXZjYzI10mO3WfB3/zF0E45TSR1kTEYkXUghntbc3TxmzK4rTxTKSfzSGEUU 7ROvTciv4DIe3VKAa/jDFIBuV5+wfquINTSaU+hfKhoUV5lp4AsrgNuB0jEN9AZltqle hjmROeY9G5p8/EY3101PjKr+8BYDUiIBm2U9yFCvn+t8RRJLKQOESV1pINTsdg58rn4p BxHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=GObavgV+Z4fgQXJ9pSIPixfXgFzveZNYSHXO7GYmt8Y=; b=2ec+IYxgZjOearyr1vPelTVEBxK6q3rnBPJRyZ3WD3R+yDdRXqEVyDwLRSy9Ac7Ifu eqnsdwsbypBgLD2xpCLGbh+JTcycp02Qi0d2zSOPTtmQ9QnnZ18YRQdXXHF84rfvGn+Y mV03vdQDBe7BOHOerVztzGdSjhDFLvjz1NpJtL+Ipz3O3kQNvItrNPRYN72ohzeAzKVQ 1DZUEPUsrhHMnS2wcKpTFAYdue5WRwUSqYfbHNN5Awz9SS8KRWABc8h8THex5h+CSr9P tBr3T/0y5jZ7Y4/4K+P7179RPmL95+73a/LYoZ+fCNTHC+7VntosStQ8EpDa68TLGU/g tMQQ== X-Gm-Message-State: ACgBeo19VRBQkTW1mNxES/yvgOqn4eelp25j8N8IaJ/N85GjcaudGOT6 wlTQE52p7ubTLAxZrC0Ye65C/bn/+HN+5y+DJWhovQ== X-Google-Smtp-Source: AA6agR6o4i5RekO57FSItsgJ7sPlgv3jHogrsnUy+QoSVGPMqvbTnwks4kLMMlDIlajwCNiI3w5dKS/jLOX/JCtA+kM= X-Received: by 2002:a9f:2067:0:b0:387:984d:4a8e with SMTP id 94-20020a9f2067000000b00387984d4a8emr8513302uam.60.1660654508354; Tue, 16 Aug 2022 05:55:08 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202208151849.27FInHmh027652@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 16 Aug 2022 06:54:57 -0600 Message-ID: Subject: Re: git: 402dbdd98acc - main - Adjust function definition in arm's mv_common.c to avoid clang 15 warning To: Alexey Dokuchaev Cc: Dimitry Andric , Jessica Clarke , Konstantin Belousov , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000010c4e505e65b42ba" X-Rspamd-Queue-Id: 4M6WMd2DJ1z4M6R X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=D96bBg1p; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::92d) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::92d:from]; R_SPF_NA(0.00)[no SPF record]; ARC_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCPT_COUNT_SEVEN(0.00)[7]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[bsdimp.com]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; FREEMAIL_CC(0.00)[freebsd.org,gmail.com] X-ThisMailContainsUnwantedMimeParts: N --00000000000010c4e505e65b42ba Content-Type: text/plain; charset="UTF-8" On Tue, Aug 16, 2022 at 5:48 AM Alexey Dokuchaev wrote: > On Tue, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote: > > ... > > But I think it is better to have the definitions matching the > > declarations exactly. We should sweep through the whole tree and get > > rid of all K&R functions too. I believe Warner wanted to attempt that. > > I won't comment on the technical side of things, but seeing this plethora > of identical commits is not just annoying, but pessimizes blaming as well. > Why can't it all be done in more coarse pieces, if not one commit? > I actually like it and don't see how it pessimizes blame. We have to do the changes, and it's better that we be able to back out or merge them one at a time. It's a huge pain to have to cherry pick a huge commit because of divergence in the target branch. Please do not take this suggestion to heart. Warner --00000000000010c4e505e65b42ba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Aug 16, 2022 at 5:48 AM Alexe= y Dokuchaev <danfe@freebsd.org&= gt; wrote:
On Tu= e, Aug 16, 2022 at 12:10:04PM +0200, Dimitry Andric wrote:
> ...
> But I think it is better to have the definitions matching the
> declarations exactly. We should sweep through the whole tree and get > rid of all K&R functions too. I believe Warner wanted to attempt t= hat.

I won't comment on the technical side of things, but seeing this pletho= ra
of identical commits is not just annoying, but pessimizes blaming as well.<= br> Why can't it all be done in more coarse pieces, if not one commit?
<= /blockquote>

I actually like it and don't see how it= pessimizes=C2=A0blame.=C2=A0 We have to do
the changes, and it&#= 39;s better that we be able to back out or merge them
one at a ti= me. It's a huge pain to have to cherry pick a huge commit because
=
of divergence in the target branch. Please do not take this suggestion= to heart.

Warner
--00000000000010c4e505e65b42ba--