Re: git: d6a461ce6716 - main - games/lolcat: update to 1.5
- In reply to: Zsolt Udvari : "Re: git: d6a461ce6716 - main - games/lolcat: update to 1.5"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 16 Jul 2024 11:58:26 UTC
> On 16. Jul 2024, at 13:47, Zsolt Udvari <uzsolt@freebsd.org> wrote: > > On Tue, Jul 16, 2024 at 08:08:19AM +0000, Alexey Dokuchaev wrote: >> PLIST_FILES are handy when there's few of them so it's easier to >> keep all things in one place (the Makefile), also makes the diffs >> shorter. Another good thing is that they are part of the options >> helpers, so one can list one or more FOO_PLIST_FILES_[OFF] while >> leaving the main pkg-plist less cluttered (no need for PLIST_SUBs). > I'm not sure "keep all things in one place" is the most important. I > prefer store everything in its own place and don't mix them, even if the > diffs is longer a bit. > Cluttered because of PLIST_SUB: yes, it's very ugly, many-many > percent sign (I hate too). One possible solution: split the pkg-plist > and the conditional parts go into separate files (e.g. pkg-plist.docs > contains the documentations, without PLIST_SUB-like prefixes). > > It's only a beginner committer's opinion, I accept the established > habits. The approach we have is based on common sense - use separate files if beneficiary, if it’s only a few entries, you might keep keep it in the Makefile (portlint also has some recommendations about it). The ports tree is huge as it is, adding lots of tiny files doesn’t help. For some ports using automatic plists makes sense too, it really depends on the port in question. -m