From nobody Tue Jul 16 11:58:26 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WNczB0m0Nz5R9rl; Tue, 16 Jul 2024 11:58:30 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WNczB0FQXz452Y; Tue, 16 Jul 2024 11:58:30 +0000 (UTC) (envelope-from grembo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721131110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nkITsoXIOYabQkQPYWs9lDNhIC/5Rn/zVK+oYDljzG0=; b=sQOmd4tEbtt+1XSyecudlhYUXUEvaJHg0atnT4MlGyD9OhPCNqmu4FLknnbEHE4t8lJLsH mkUjLpTENJvPY9e5lck3WI8KwJrX2K2zQ1hYZlud5JJOf2FEmemzka66z0eSemJQmxaXCz l8ao99mUKUQAjnzM24sgxag1N17V7TGc3Dw1ecP+R5PxUESO9SlrIdvLV+OSjWG+VOipBL P+PQKX6SjbaFHwcJNky+ypPgZkwhU7dwkxT7T1wpZl/PvPVNs0F3bfGfEPxhlDZdESJRLh zM5SWBQwWtI91k4l2CZflo6dhCtrqdrwENJIqskYH/ajYdTSrL+3QDeU9irXzA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721131110; a=rsa-sha256; cv=none; b=wWhWVVCl4ftBEbrqBwD7mPMBVKHTbW7gFJnyGl/9iCPwHVSs0FfaKffe3WwUdcqKxx3WoU xZMMksKBGdk5f+cH659POb6LvZimWAvX3S8hZAieVWLymdFvGF1U5MH7KPhCGpnkKevD6b 5X1K1eC2It2gUIgF3Hn99wBaALHlKsz3n01XokI9SXKW36XLjBGMRJDAQokNlX2fjW7p+o 0LiRYlHqccT4s4olaTqgSBhNkwClsgSH10QTVRKg+Huv8SLHIm5DBAMbYIvd6zeKPlNEL+ 8E8+S9MHgz99BzDW3rYUGwgqCEszjN9cnffkhA6mDd80ww+WGXTwYjolHueHiQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721131110; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nkITsoXIOYabQkQPYWs9lDNhIC/5Rn/zVK+oYDljzG0=; b=KZXsTpPjkTSGDFHK350/mgFEg+JFBLDwv5jJQUMMYia2bsqgJFKaSnM5Wz6IkZh4eyJV3a tGS7JPxASXht7pabBy03GYQSXmKLmblmcOODziS4Im+FjGa8IemOVxz0pkxbilp3utvn40 w/vollAOG2hQxTWRzOFoLVYdKeI5+W9lrSN1ZeBFr5eNFuNZnqQESfokqqg13vHqgviOwV OeuZ3hIq4VI5Ym9I/rsMQt0ZzizCtAq3QbRMD1NyMA3lNOWKBXZmd3roOe6LJM6xJFN2s+ pBlKB14N1vRgXuI7GJ8S0KwL20+v4O0IzvEMDAbxG6Pas0Yl1ZLi3xiiNeVAzA== Received: from mail.evolve.de (mail.evolve.de [213.239.217.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.evolve.de", Issuer "R10" (verified OK)) (Authenticated sender: grembo/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4WNcz92jYhzWmM; Tue, 16 Jul 2024 11:58:29 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: by mail.evolve.de (OpenSMTPD) with ESMTPSA id 64ec4984 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 16 Jul 2024 11:58:28 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org Mime-Version: 1.0 (1.0) Subject: Re: git: d6a461ce6716 - main - games/lolcat: update to 1.5 From: Michael Gmelin In-Reply-To: Date: Tue, 16 Jul 2024 13:58:26 +0200 Cc: Alexey Dokuchaev , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Message-Id: <20C8F444-FC44-4FC5-8871-D5DF64549C7E@freebsd.org> References: To: Zsolt Udvari X-Mailer: iPhone Mail (20H343) > On 16. Jul 2024, at 13:47, Zsolt Udvari wrote: >=20 > =EF=BB=BFOn Tue, Jul 16, 2024 at 08:08:19AM +0000, Alexey Dokuchaev wrote:= >> PLIST_FILES are handy when there's few of them so it's easier to >> keep all things in one place (the Makefile), also makes the diffs >> shorter. Another good thing is that they are part of the options >> helpers, so one can list one or more FOO_PLIST_FILES_[OFF] while >> leaving the main pkg-plist less cluttered (no need for PLIST_SUBs). > I'm not sure "keep all things in one place" is the most important. I > prefer store everything in its own place and don't mix them, even if the > diffs is longer a bit. > Cluttered because of PLIST_SUB: yes, it's very ugly, many-many > percent sign (I hate too). One possible solution: split the pkg-plist > and the conditional parts go into separate files (e.g. pkg-plist.docs > contains the documentations, without PLIST_SUB-like prefixes). >=20 > It's only a beginner committer's opinion, I accept the established > habits. The approach we have is based on common sense - use separate files if benefi= ciary, if it=E2=80=99s only a few entries, you might keep keep it in the Mak= efile (portlint also has some recommendations about it). The ports tree is h= uge as it is, adding lots of tiny files doesn=E2=80=99t help. For some ports= using automatic plists makes sense too, it really depends on the port in qu= estion. -m