Re: git: d6a461ce6716 - main - games/lolcat: update to 1.5

On Tue, Jul 16, 2024 at 08:08:19AM +0000, Alexey Dokuchaev wrote:
> PLIST_FILES are handy when there's few of them so it's easier to
> keep all things in one place (the Makefile), also makes the diffs
> shorter.  Another good thing is that they are part of the options
> helpers, so one can list one or more FOO_PLIST_FILES_[OFF] while
> leaving the main pkg-plist less cluttered (no need for PLIST_SUBs).
I'm not sure "keep all things in one place" is the most important. I
prefer store everything in its own place and don't mix them, even if the
diffs is longer a bit.
Cluttered because of PLIST_SUB: yes, it's very ugly, many-many
percent sign (I hate too). One possible solution: split the pkg-plist
and the conditional parts go into separate files (e.g. pkg-plist.docs
contains the documentations, without PLIST_SUB-like prefixes).

It's only a beginner committer's opinion, I accept the established
habits.

Cheers,
  Zsolt