Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS

> On Apr 12, 2023, at 3:43 PM, Alexey Dokuchaev <danfe@freebsd.org> wrote:
> 
> On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman wrote:
>> commit c89b6f2799891129e89d1b4fedf8e25865241060
>> 
>>  lang/php8[12]: Fix build on aarch64 with ZTS
>> 
>>  - Refresh patches
> 
> What good did it bring other than cloaking the actual fix with tons
> of needless, unrelated changes?  You've poured a glass of honey into
> a bucket of tar. :(
> 
>>  PR:             266175
>>  Reported by:    thresh@nginx.com
> 
> That's pretty scarce description.  PR was closed as non-actionable
> because you didn't have access to aarch64, until someone(tm) came along
> and pointed out the upstream commit that broke the build.  You didn't
> describe the problem after that, you ignored most of the comments on
> that PR, including the one to reopen it, and of course you failed to
> give proper credit in the commit log.
> 
> This is *not* how we do things in FreeBSD.
1. You are not someone who should be saying how we do things in FreeBSD
because you yourself do not follow our commit guidelines.

2. The patches were submitted by fluffy@ and the log says that the author
is "Author:     Dima Panov <fluffy@FreeBSD.org <mailto:fluffy@FreeBSD.org>>" so I am not sure how I failed to
give proper credit. Undoubtedly you commented on this email without reading
it properly.

As I am a very little entity into the project I will give you a life advice
rather than a FreeBSD related one. When you are pointing fingers to others
there are three fingers pointing towards yourself.

Kind regards,
Moin
> ./danfe