From nobody Wed Apr 12 14:43:13 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PxQSB3YGgz44t2H; Wed, 12 Apr 2023 14:43:22 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PxQSB2vjTz4KRb; Wed, 12 Apr 2023 14:43:22 +0000 (UTC) (envelope-from bofh@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681310602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h334tnue4LraNHrYNfDMRxFiFax6BxSAGTf1lpE9EMo=; b=JVzfc6zFmlTDbgnxkQTPYYobtaOr/oKALHlacu48aKKRVLMFOchQZlk229mPb0+9K1Xro6 x/KSJd4FJK0KzVvdHEpKZNY+KmK25hMwozTnMgx3E5hNYqZYegC68POs28227AUEwjB0br L80dr89onYdb8GLfIZqtnN7/l3/Q2Ajol9wXoSGQl1T8OblkMNZApp9EO7gM0qeF4sdtUp 4Ry0Aupmcw9JqFE9nvMPz7vIuGE+q5Ct4fwg0F3HR/uDJH6L/QNtlb/1caXSa1E0/vdsfl GcK/0P+GGdX+kcgMYPkpRs2nZdHrx0OvlZWmpKO43Tp9dpqT1Y7z5RX+l+5JgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681310602; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h334tnue4LraNHrYNfDMRxFiFax6BxSAGTf1lpE9EMo=; b=S2oAa9VF4+OcCfzfAMOHiKgZnZ1hV9tozlKR1zC/pw3HEOyV9RY0CZsk5MQyvWBzgBxl95 MpfzcNDoLNaQz3nuiPgrWtkJ/erEPIp4ZvvKuExHIG7lPx0f69ok6O8eVyRr9EBF8LrCac nX6YqiqqyYZvIHQG/Pw+l+PuaFaS+TdlDYqtq1DNvvP2Hqus/Sfl9h/aSUuhBEFKZpO8Na zs1oVZydWuFsleCg/i0hdsr3AWUdDKpWrZsWLHOMnKWRROrM2vlYyoi8Yn7wHKE3TxuDmB z8yaAqiBQH2RiH88wIUZ7gQ8EBuQ+Ssto8ocQf/Yk58hjzKnwHa6RYq2jUhc/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681310602; a=rsa-sha256; cv=none; b=u10+7MqvpiMZ16fQvWfQNSKGRhwa/zsuhrcA1qAxA4N5xrsDoMfV3//5BE3OqOII0Ds5YN 1zMlqQ2LRIdbqZM00FWxiq9RvMkYH9EIzkTpOPhpqTgIg5/TmBKp3rioMCgPm8OxBVG8aH +sZPeR+eNNkjeeivCMhLXT3xclOFBLh2oRlBcxrhkD8wZUWH1NzKzWp6Cm7x2nmNmtwMrs 7JPLBnfYm1MBmLwCK94YtLJq/8c56h566ruegNdEP9UB2N4hYC+Yhtxvc9iu733lAd8Kcj MNeD1yms1BfwaWoNWsRLO3qmF/NKRw9Qg/yZgIbA+NZCjAsxv5v9kR4oXOBpiQ== Received: from mx.bofh.network (mx.bofh.network [IPv6:2a01:4f8:261:25de::227]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature ECDSA (P-256) client-digest SHA256) (Client CN "mx.bofh.network", Issuer "R3" (verified OK)) (Authenticated sender: bofh/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4PxQS954zczFmy; Wed, 12 Apr 2023 14:43:21 +0000 (UTC) (envelope-from bofh@freebsd.org) Received: from smtpclient.apple (gw.office.cyso.net [95.97.78.194]) by mx.bofh.network (OpenSMTPD) with ESMTPSA id 98113314 (TLSv1.2:ECDHE-ECDSA-AES256-GCM-SHA384:256:NO); Wed, 12 Apr 2023 14:43:16 +0000 (UTC) From: Moin Rahman Message-Id: <1FBC4A00-F91C-4A4C-9D3E-A159287BCA43@freebsd.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_A4F2BC45-E396-4B84-89B2-884351044FD3" List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS Date: Wed, 12 Apr 2023 16:43:13 +0200 In-Reply-To: Cc: "" , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org To: Alexey Dokuchaev References: <202304120539.33C5dOJA014331@gitrepo.freebsd.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_A4F2BC45-E396-4B84-89B2-884351044FD3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Apr 12, 2023, at 3:43 PM, Alexey Dokuchaev = wrote: >=20 > On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman = wrote: >> commit c89b6f2799891129e89d1b4fedf8e25865241060 >>=20 >> lang/php8[12]: Fix build on aarch64 with ZTS >>=20 >> - Refresh patches >=20 > What good did it bring other than cloaking the actual fix with tons > of needless, unrelated changes? You've poured a glass of honey into > a bucket of tar. :( >=20 >> PR: 266175 >> Reported by: thresh@nginx.com >=20 > That's pretty scarce description. PR was closed as non-actionable > because you didn't have access to aarch64, until someone(tm) came = along > and pointed out the upstream commit that broke the build. You didn't > describe the problem after that, you ignored most of the comments on > that PR, including the one to reopen it, and of course you failed to > give proper credit in the commit log. >=20 > This is *not* how we do things in FreeBSD. 1. You are not someone who should be saying how we do things in FreeBSD because you yourself do not follow our commit guidelines. 2. The patches were submitted by fluffy@ and the log says that the = author is "Author: Dima Panov >" so I am not sure how I failed to give proper credit. Undoubtedly you commented on this email without = reading it properly. As I am a very little entity into the project I will give you a life = advice rather than a FreeBSD related one. When you are pointing fingers to = others there are three fingers pointing towards yourself. Kind regards, Moin > ./danfe --Apple-Mail=_A4F2BC45-E396-4B84-89B2-884351044FD3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii

On Apr 12, 2023, at 3:43 PM, Alexey Dokuchaev <danfe@freebsd.org> = wrote:

On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur = Rahman wrote:
commit = c89b6f2799891129e89d1b4fedf8e25865241060

=  lang/php8[12]: Fix build on aarch64 with ZTS

 - Refresh patches

What good did it bring other than cloaking the actual fix = with tons
of needless, unrelated changes?  You've = poured a glass of honey into
a bucket of tar. :(

=  PR: =             26= 6175
 Reported by:    thresh@nginx.com

That's pretty scarce description. =  PR was closed as non-actionable
because you didn't = have access to aarch64, until someone(tm) came along
and = pointed out the upstream commit that broke the build.  You = didn't
describe the problem after that, you ignored most = of the comments on
that PR, including the one to reopen = it, and of course you failed to
give proper credit in the = commit log.

This is *not* how we do things = in FreeBSD.
1. You are not = someone who should be saying how we do things in = FreeBSD
because you yourself do not follow our commit = guidelines.

2. The patches were = submitted by fluffy@ and the log says that the author
is = "Author:     Dima Panov <fluffy@FreeBSD.org>" so I am not sure how I failed = to
give proper credit. Undoubtedly you commented on = this email without reading
it properly.

As I am a very little entity into the project I = will give you a life advice
rather than a FreeBSD related one. = When you are pointing fingers to others
there are three = fingers pointing towards yourself.

Kind regards,
Moin
./danfe

= --Apple-Mail=_A4F2BC45-E396-4B84-89B2-884351044FD3--