Re: git: c89b6f279989 - main - lang/php8[12]: Fix build on aarch64 with ZTS

On Wed, Apr 12, 2023 at 05:39:24AM +0000, Muhammad Moinur Rahman wrote:
> commit c89b6f2799891129e89d1b4fedf8e25865241060
> 
>   lang/php8[12]: Fix build on aarch64 with ZTS
> 
>   - Refresh patches

What good did it bring other than cloaking the actual fix with tons
of needless, unrelated changes?  You've poured a glass of honey into
a bucket of tar. :(

>   PR:             266175
>   Reported by:    thresh@nginx.com

That's pretty scarce description.  PR was closed as non-actionable
because you didn't have access to aarch64, until someone(tm) came along
and pointed out the upstream commit that broke the build.  You didn't
describe the problem after that, you ignored most of the comments on
that PR, including the one to reopen it, and of course you failed to
give proper credit in the commit log.

This is *not* how we do things in FreeBSD.

./danfe