Device departure processing

[Pawel Jakub Dawidek]

On Sat, Feb 05, 2011 at 07:56:01PM -0700, Justin T. Gibbs wrote:
> On 2/4/2011 3:52 PM, Pawel Jakub Dawidek wrote:
> > On Mon, Jan 31, 2011 at 02:39:08PM -0700, Justin T. Gibbs wrote:
> > 
> >> >From a brief review of the v28 code, it seems appropriate there too.
> >> The code in vdev_geom_orphan is identical save for an added call to
> >> zfs_post_remove().  In our port, this call appears to do nothing more
> >> than to post the devctl notice event a little earlier than via the
> >> scheduled removal of the device by the spa code.  Is there some benefit
> >> I'm missing that makes the zfs_post_remove() necessary?
> > 
> > Without it I see no info about vdev removal in devd.
> 
> Do you know why the call to zfs_post_remove() was removed from
> vdev_set_state()?  This is where the notification is made in -current (v15).
> It seems wrong to put this policy into each vdev driver instead of
> just doing it in the common vdev code.

This was changed in 2a8816c5173b. And the added comment states:

	/*
	 * We post the resource as soon as possible, instead of
	 * when the async removal actually happens, because the
	 * DE is using this information to discard previous I/O
	 * errors.
	 */
	zfs_post_remove(zio->io_spa, vd);

This is from vdev_disk.c.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/zfs-devel/attachments/20110206/1920c869/attachment.pgp