Device departure processing

Justin T. Gibbs gibbs at scsiguy.com
Sun Feb 6 02:56:07 UTC 2011


On 2/4/2011 3:52 PM, Pawel Jakub Dawidek wrote:
> On Mon, Jan 31, 2011 at 02:39:08PM -0700, Justin T. Gibbs wrote:
> 
>> >From a brief review of the v28 code, it seems appropriate there too.
>> The code in vdev_geom_orphan is identical save for an added call to
>> zfs_post_remove().  In our port, this call appears to do nothing more
>> than to post the devctl notice event a little earlier than via the
>> scheduled removal of the device by the spa code.  Is there some benefit
>> I'm missing that makes the zfs_post_remove() necessary?
> 
> Without it I see no info about vdev removal in devd.

Do you know why the call to zfs_post_remove() was removed from
vdev_set_state()?  This is where the notification is made in -current (v15).
It seems wrong to put this policy into each vdev driver instead of
just doing it in the common vdev code.

--
Justin


More information about the zfs-devel mailing list