svn commit: r258124 - head/usr.sbin/portsnap/portsnap

[Colin Percival]

On 11/14/13 01:47, Robert Watson wrote:
> On Thu, 14 Nov 2013, Colin Percival wrote:
>>  When verifying that files we need are present, also check that they don't
>>  have zero length.  Filesystem corruption will tend to truncate files, and
>>  since these are short that's likely to result in them becoming empty.
> 
> I think I'd probably express this slightly differently: the filesystem isn't
> corrupted, it just doesn't contain the data you expect.  As filesystems don't
> guarantee data is there until fsync() has returned, it is actually meeting all
> its promises -- e.g., vs corrupted inode contents due to a filesystem bug.

True, I should have written "crashes resulting in data loss".

-- 
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid