svn commit: r258124 - head/usr.sbin/portsnap/portsnap
Robert Watson
rwatson at FreeBSD.org
Thu Nov 14 09:47:18 UTC 2013
On Thu, 14 Nov 2013, Colin Percival wrote:
> Log:
> When verifying that files we need are present, also check that they don't
> have zero length. Filesystem corruption will tend to truncate files, and
> since these are short that's likely to result in them becoming empty.
>
> Suggested by: Richard Clayton
> Convinced by: rwatson
> MFC after: 3 weeks
I think I'd probably express this slightly differently: the filesystem isn't
corrupted, it just doesn't contain the data you expect. As filesystems don't
guarantee data is there until fsync() has returned, it is actually meeting all
its promises -- e.g., vs corrupted inode contents due to a filesystem bug.
Robert
More information about the svn-src-head
mailing list