svn commit: r346295 - in head/sys: arm/allwinner arm/altera/socfpga arm/amlogic/aml8726 arm/annapurna/alpine arm/broadcom/bcm2835 arm/freescale/imx arm/freescale/vybrid arm/mv arm/nvidia/tegra124 a...

[Warner Losh]

On Wed, Apr 17, 2019 at 12:06 PM Andrew Turner <andrew at fubar.geek.nz> wrote:

>
>
> On 17 Apr 2019, at 17:52, Ian Lepore <ian at freebsd.org> wrote:
>
> On Wed, 2019-04-17 at 11:23 +0200, Andrew Turner wrote:
>
> On 16 Apr 2019, at 22:04, Emmanuel Vadot <manu at freebsd.org> wrote:
>
> Author: manu
> Date: Tue Apr 16 20:04:22 2019
> New Revision: 346295
> URL: https://svnweb.freebsd.org/changeset/base/346295
>
> Log:
> arm: Add kern_clocksource.c directly in files.arm
>
> This files is needed and included in all our config so move it to
> a common
> location.
>
> MFC after: 2 weeks
>
>
> ...
>
> Modified: head/sys/conf/files.arm
> ===================================================================
> ===========
> --- head/sys/conf/files.arm Tue Apr 16 19:46:02 2019 (r346294)
> +++ head/sys/conf/files.arm Tue Apr 16 20:04:22 2019 (r346295)
> @@ -11,6 +11,9 @@ cloudabi32_vdso_blob.o optional com
> pat_cloudabi32 \
> no-implicit-rule \
> clean "cloudabi32_vdso_blob.o"
> #
> +
> +kern/kern_clocksource.c standard
>
>
> Could this be moved from the various files.* to files? It seems we
> define it as standard on all architectures.
>
>
>
> I thought mips still had some variants that didn't implement event
> timers.  That's why this stuff was ever in arch-specific files, arm and
> mips had some flavors without ET support.
>
>
> I think it used to be the case on arm. A grep seems to think it’s enabled
> on all architectures now:
>
> grep kern_clocksource files.*
> files.amd64:kern/kern_clocksource.c standard
> files.arm:kern/kern_clocksource.c standard
> files.arm64:kern/kern_clocksource.c standard
> files.i386:kern/kern_clocksource.c standard
> files.mips:kern/kern_clocksource.c standard
> files.powerpc:kern/kern_clocksource.c standard
> files.riscv:kern/kern_clocksource.c standard
> files.sparc64:kern/kern_clocksource.c standard
>

Looks like it can be hoisted and required for all new architectures.

Warner