svn commit: r313675 - in head/sys: netinet netinet6

[Glen Barber]

On Sun, Feb 12, 2017 at 08:24:26AM -0800, Cy Schubert wrote:
> In message <53D3A92C-6C64-4C0C-A5E6-B659BFA139BF at neville-neil.com>, "George Neville-Neil" writes:
> > This is an OpenPGP/MIME signed message (RFC 3156 and 4880).
> > On 12 Feb 2017, at 6:10, Glen Barber wrote:
> > > On Sun, Feb 12, 2017 at 06:56:33AM +0000, Ermal Lu=C3=A7i wrote:
> > >> Author: eri
> > >> Date: Sun Feb 12 06:56:33 2017
> > >> New Revision: 313675
> > >> URL: https://svnweb.freebsd.org/changeset/base/313675
> > >>
> > >> Log:
> > >>   Committed without approval from mentor.
> > >>
> > >>   Reported by:	gnn
> > >>
> > >
> > > What exactly does this mean?
> > >
> > 
> > Ermal took the Acceptance on reviews.freebsd.org by Adrian as an implicit
> >  "go ahead" to commit to the tree.  The issue is that he's still under
> > mentorship, by me, and had not gotten an approval or had an Approved by:
> > line.  I asked him to revert the change himself.
> > 
> > We're working out a few more issues in the review now.
> 
> I didn't read this when I hit send on my email. Hopefully nobody takes 
> offense. I was upset and still am.
> 
> I still think that the revision numbers of any backout should have been 
> documented in the commit log.
> 

I absolutely agree, and was the key meaning behind my "what exactly does
this mean?" reply.  The commit log, as-is, provides nothing useful to
the reader.

> Something we could do, as is expected by re@ for commits during a freeze, 
> is metees also let their mentors know of what the contents of commit log 
> messages will be. I think commit log messages discussing the what, why and 
> rationale are as important as the code itself.
> 

I thought this was standard practice.  But if not, I would agree that
both code changes and the commit log should be both approved by the
mentor.

Just my $0.02 USD.

Glen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-src-all/attachments/20170212/479a7956/attachment.sig>