svn commit: r476193 - in head/audio/lame: . files

[Alexander Leidinger]

Quoting Jan Beich <jbeich at freebsd.org> (from Wed, 01 Aug 2018 22:35:49 +0200):

> Alexander Leidinger <netchild at FreeBSD.org> writes:
>
>> Author: netchild
>> Date: Wed Aug  1 20:01:27 2018
>> New Revision: 476193
>> URL: https://svnweb.freebsd.org/changeset/ports/476193
>>
>> Log:
>>   Move patents text from the Makefile to a file.
>>   While I'm here, make it more an explanatory text than just a
>>   copy&paste from the previous comment of the Makefile.
>>
>>   Requested by:	portmgr (mat)
> [...]
>> +LICENSE_FILE_PATENTS=	$(FILESDIR)/lame_patents.txt
>
> $(...) isn't consistent with the rest of the file.

Ooops.

> $ portlint -C
> WARN: Makefile: [18]: use ${VARIABLE}, instead of $(VARIABLE).
> FATAL: Makefile: LICENSE_NAME_PATENTS appears out-of-order.
> FATAL: Makefile: LICENSE_FILE_PATENTS appears out-of-order.
> FATAL: Makefile: order must be  
> LICENSE/LICENSE_COMB/LICENSE_GROUPS(_\w+)?/LICENSE_NAME(_\w+)?/LICENSE_TEXT(_\w+)?/LICENSE_FILE(_\w+)?/LICENSE_PERMS(_\w+)?/LICENSE_DISTFILES(_\w+)?.
> 3 fatal errors and 1 warning found.

May I challenge the order? LICENSE shall be ordered alphabetically,  
and then we mix the patent grouped parts... Looks strange to me. If  
you look at the result after your patch, it goes to PATENTS, then LGPL  
then PATENTS again. For me the natural grouping is per license, so  
first all the variables for the first license, then all for the  
second. Alphabetical order is off course easy to implement in tools  
like portlint, and easy so teach to maintainers, but for the Mk files  
it doesn't matter, and in my opinion we should change that to group  
per license, as it is less context-switching from one license to  
another for the person which looks at multi-license ports.

Bye,
Alexander.

> Index: audio/lame/Makefile
> ===================================================================
> --- audio/lame/Makefile	(revision 476196)
> +++ audio/lame/Makefile	(working copy)
> @@ -12,10 +12,10 @@ COMMENT=	Fast MP3 encoder kit
>
>  LICENSE=		LGPL20+ PATENTS
>  LICENSE_COMB=		multi
> +LICENSE_NAME_PATENTS=	Intellectual Property Precaution
>  LICENSE_FILE_LGPL20+ =	${WRKSRC}/COPYING
> -LICENSE_NAME_PATENTS=	Intellectual Property Precaution
> +LICENSE_FILE_PATENTS=	${FILESDIR}/lame_patents.txt
>  LICENSE_PERMS_PATENTS=	dist-mirror dist-sell no-pkg-mirror  
> no-pkg-sell auto-accept
> -LICENSE_FILE_PATENTS=	$(FILESDIR)/lame_patents.txt
>
>  USES=		gmake iconv libtool
>  USE_LDCONFIG=	yes


-- 
http://www.Leidinger.net Alexander at Leidinger.net: PGP 0x8F31830F9F2772BF
http://www.FreeBSD.org    netchild at FreeBSD.org  : PGP 0x8F31830F9F2772BF
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: Digitale PGP-Signatur
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20180802/1e574619/attachment.sig>