svn commit: r476193 - in head/audio/lame: . files

[Jan Beich]

Alexander Leidinger <netchild at FreeBSD.org> writes:

> Author: netchild
> Date: Wed Aug  1 20:01:27 2018
> New Revision: 476193
> URL: https://svnweb.freebsd.org/changeset/ports/476193
>
> Log:
>   Move patents text from the Makefile to a file.
>   While I'm here, make it more an explanatory text than just a
>   copy&paste from the previous comment of the Makefile.
>   
>   Requested by:	portmgr (mat)
[...]
> +LICENSE_FILE_PATENTS=	$(FILESDIR)/lame_patents.txt

$(...) isn't consistent with the rest of the file.

$ portlint -C
WARN: Makefile: [18]: use ${VARIABLE}, instead of $(VARIABLE).
FATAL: Makefile: LICENSE_NAME_PATENTS appears out-of-order.
FATAL: Makefile: LICENSE_FILE_PATENTS appears out-of-order.
FATAL: Makefile: order must be LICENSE/LICENSE_COMB/LICENSE_GROUPS(_\w+)?/LICENSE_NAME(_\w+)?/LICENSE_TEXT(_\w+)?/LICENSE_FILE(_\w+)?/LICENSE_PERMS(_\w+)?/LICENSE_DISTFILES(_\w+)?.
3 fatal errors and 1 warning found.

Index: audio/lame/Makefile
===================================================================
--- audio/lame/Makefile	(revision 476196)
+++ audio/lame/Makefile	(working copy)
@@ -12,10 +12,10 @@ COMMENT=	Fast MP3 encoder kit
 
 LICENSE=		LGPL20+ PATENTS
 LICENSE_COMB=		multi
+LICENSE_NAME_PATENTS=	Intellectual Property Precaution
 LICENSE_FILE_LGPL20+ =	${WRKSRC}/COPYING
-LICENSE_NAME_PATENTS=	Intellectual Property Precaution
+LICENSE_FILE_PATENTS=	${FILESDIR}/lame_patents.txt
 LICENSE_PERMS_PATENTS=	dist-mirror dist-sell no-pkg-mirror no-pkg-sell auto-accept
-LICENSE_FILE_PATENTS=	$(FILESDIR)/lame_patents.txt
 
 USES=		gmake iconv libtool
 USE_LDCONFIG=	yes