svn commit: r366405 - in head/databases: . p5-Net-Async-CassandraCQL

[Kurt Jaeger]

Hi!

> > > In real life, modules from Test:: namespace usually requires only for
> > > tests. No issue for people who using binary packages, but extra deps for
> > > people who still using ports.
[...]
> > So I assume BUILD_DEPENDS is correct. Do you see other options
> > on how to handle this ?

First, thanks for the many hints on how to handle this.

> TEST_DEPENDS is correct.

I've prepared a diff at

http://people.freebsd.org/~pi/misc/cascql.svndiff

When I 

make test

the TEST_DEPENDS are not installed:

[...]
t/21prepare.t ............... Can't locate Test/Identity.pm in @INC
[...]

How is TEST_DEPENDS supposed to be used so that this works for
the 'make test' case, but not the 'make install' case ?

> The author should use "test_requires" instead of "build_requires" in this
> case.

So an upstream PR is required ? Or is it only recommended ?

> The following results show that Test::{Identity,Refcount} are only for test
> purpose and not required for runtime.
>
> % grep -r Test::Identity *
[...]

Ok, I'll add this to my checks.

> For p5-* ports, please make sure the modules listed in Build.PL or
> Makefile.PL are truly required.
> At least a simply "grep" would help to determine if TEST_DEPENDS is more
> suitable, especially for Test::* dependencies.
> 
> BTW, there are something can be improved in the Makefile:
> - MASTER_SITE_SUBDIR is unnecessary.
> - Please respect minimal version requirement in Build.PL / Makefile.PL, e.g.
>   Future: '0.17'
>   IO::Async::Loop: '0.54'
>   IO::Async::Stream: '0.59'
>   Protocol::CassandraCQL: '0.11'
> -
> "devel/p5-Devel-GlobalDestruction>0:${PORTSDIR}/devel/p5-Devel-GlobalDestruction"
> is incorrect

Those are fixed in the svndiff above. I'll commit it if no further
changes are required. I'm still unsure about the TEST_DEPENDS issue.

-- 
pi at FreeBSD.org         +49 171 3101372                6 years to go !