Commit logs for 2014/04/11

[Bryan Drewery]

On 2014-04-21 05:07, Alexey Dokuchaev wrote:
> On Sun, Apr 20, 2014 at 02:35:25PM -0500, Bryan Drewery wrote:
>> > On Apr 20, 2014, at 4:29, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
>> >> On Sat, Apr 12, 2014 at 10:11:44AM -0400, Adam Weinberger wrote:
>> >> * Please, please don't mandate .sample. Plenty of of ports install
>> >
>> > Actually, it's not really ".sample".  It's any six-letter word if I read the
>> > code correctly.
>> 
>> No. It is literally only .sample.
> 
> Right; I forgot to check the other file, sample.yaml.
> 
>> >>  sample conf files with different extension. "-dist" is very common
>> >>  for php ports, for example. Let @sample take two arguments. Like
>> >>    @sample etc/pants.conf-dist pants.conf
>> >
>> > Why do we need the second argument?  Can't we just use the rightmost
>> > extension?  Proof of concept attached.
>> 
>> I would think you would support consistency :)
> 
> Well, at first it seemed like a nice idea that could be implemented 
> without
> sacrificing much consistency.  After received feedback, I'm no longer 
> sure
> about it, so I guess I'm fine with ".sample", at least for the time 
> being.
> 
> ./danfe

It's a tough decision. It's not exactly simple to support an arbitrary
extension. Pkg does not support arguments for Keywords. Some extensions
are -dist. Which should have precedence over a file having both '.'
and '-'? What if they have neither?

My original PoC had support for -dist and .sample, but discussing with 
bapt
we decided on making an implicit policy of files being installed as
.sample. It's nicer for users if all sample/dist/original files are
named the same. I'm still in favor of supporting '-dist' as well.

-- 
Regards,
Bryan Drewery