Commit logs for 2014/04/11

Alexey Dokuchaev danfe at FreeBSD.org
Mon Apr 21 10:07:36 UTC 2014


On Sun, Apr 20, 2014 at 02:35:25PM -0500, Bryan Drewery wrote:
> > On Apr 20, 2014, at 4:29, Alexey Dokuchaev <danfe at FreeBSD.org> wrote:
> >> On Sat, Apr 12, 2014 at 10:11:44AM -0400, Adam Weinberger wrote:
> >> * Please, please don't mandate .sample. Plenty of of ports install
> > 
> > Actually, it's not really ".sample".  It's any six-letter word if I read the
> > code correctly.
> 
> No. It is literally only .sample.

Right; I forgot to check the other file, sample.yaml.

> >>  sample conf files with different extension. "-dist" is very common
> >>  for php ports, for example. Let @sample take two arguments. Like
> >>    @sample etc/pants.conf-dist pants.conf
> > 
> > Why do we need the second argument?  Can't we just use the rightmost
> > extension?  Proof of concept attached.
> 
> I would think you would support consistency :)

Well, at first it seemed like a nice idea that could be implemented without
sacrificing much consistency.  After received feedback, I'm no longer sure
about it, so I guess I'm fine with ".sample", at least for the time being.

./danfe


More information about the svn-ports-all mailing list