svn commit: r325805 - head/Mk

[Bryan Drewery]

Looking now

Sent from my iPhone

On Sep 1, 2013, at 8:07, Sahil Tandon <sahil at tandon.net> wrote:

> On Sun, 2013-09-01 at 12:59:28 +0200, Anton Berezin wrote:
> [ .. ]
>>>  => Attempting to fetch
>>>  ftp://ftp.porcupine.org/mirrors/postfix-release/experimental/postfix-2.11-20130825.tar.gz
>>>  postfix-2.11-20130825.tar.gz                  100% of 3866 kB  910
>>>  kBps
>>>  [: -eq: argument expected
>>>  => Fetched file size mismatch (expected , actual 3959547)
>>>  => Trying next site
>>> 
>>> This only happens if the distfile does not already exist (and therefore
>>> needs to be fetched), and I 'make makesum'.  Apparently, CKSIZE is
>>> undefined.  Notably, if I 'make fetch' first, and then 'make makesum',
>>> there is no problem.
>> 
>> I see the same behavior.  So, updating ports is kinda broken at the moment.
> 
> Looking at this a bit more, and I believe it happens because the makesum
> target calls the fetch target with DISABLE_SIZE=yes, and earlier in
> bsd.port.mk, we have:
> 
>  .if !defined(DISABLE_SIZE)
>  FETCH_BEFORE_ARGS+=     $${CKSIZE:+-S $$CKSIZE}
>  .endif
> 
> Because CKSIZE is undefined, the following comparison inside the fetch
> target does not work as intended:
> 
>  if [ $${actual_size} -eq $${CKSIZE} ]; then \
> 
> Hope this helps.
> 
> -- 
> Sahil Tandon