svn commit: r314859 - head/palm/jpilot

[Bryan Drewery]

On 3/22/2013 10:12 AM, Baptiste Daroussin wrote:
> On Fri, Mar 22, 2013 at 02:53:44PM +0000, Alexey Dokuchaev wrote:
>> On Fri, Mar 22, 2013 at 06:42:55PM +0400, Boris Samorodov wrote:
>>> 21.03.2013 22:27, Baptiste Daroussin пишет:
>>>> --- head/palm/jpilot/Makefile	Thu Mar 21 18:25:04 2013	(r314858)
>>>> +++ head/palm/jpilot/Makefile	Thu Mar 21 18:27:17 2013	(r314859)
>>> [...]
>>>> -# "?=" and "+=" are for including this Makefile from japanese/jpilot
>>>
>>> Not particular to this commit, but rather a general question:
>>> what is our current policy on comments at the makefile headers?
>>> I mean non-standard comments (maintainer tips, etc.). Should
>>> they be deleted?
>>
>> I would not delete them (in general case).  In this particular case I assume
>> they were deleted because they were stating quite obvious thing: certain
>> variables with +=/?= are clear indication of master/slave relationship.
>>
>> ./danfe
> 
> Deleting was a mistake, I will readd them once I'm back on a box where I can
> commit on the ports tree.
> 
> Meaning probably monday.
> 
> Except if somone wants to do it now, he gets my approval.
> 
> regards,
> Bapt
> 

Fixed

-- 
Regards,
Bryan Drewery
bdrewery at freenode/EFNet

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 898 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130322/aba3959b/attachment.sig>