svn commit: r314859 - head/palm/jpilot

[Baptiste Daroussin]

On Fri, Mar 22, 2013 at 07:06:07PM +0400, Boris Samorodov wrote:
> 22.03.2013 18:53, Alexey Dokuchaev пишет:
> > On Fri, Mar 22, 2013 at 06:42:55PM +0400, Boris Samorodov wrote:
> >> 21.03.2013 22:27, Baptiste Daroussin пишет:
> >>> --- head/palm/jpilot/Makefile	Thu Mar 21 18:25:04 2013	(r314858)
> >>> +++ head/palm/jpilot/Makefile	Thu Mar 21 18:27:17 2013	(r314859)
> >> [...]
> >>> -# "?=" and "+=" are for including this Makefile from japanese/jpilot
> >>
> >> Not particular to this commit, but rather a general question:
> >> what is our current policy on comments at the makefile headers?
> >> I mean non-standard comments (maintainer tips, etc.). Should
> >> they be deleted?
> > 
> > I would not delete them (in general case).
> 
> ACK.
> 
> > In this particular case I assume
> > they were deleted because they were stating quite obvious thing: certain
> > variables with +=/?= are clear indication of master/slave relationship.
> 
> Unfortunately our standard tool makes this:
> -----
> bsam% cd /usr/ports/palm/jpilot
> 
> bsam% grep ^# Makefile
> # Created by: Alex Varju <varju at webct.com>
> # $FreeBSD: head/palm/jpilot/Makefile 314859 2013-03-21 18:27:17Z bapt $
> # Do not edit this makefile header!!!
> 
> bsam% /usr/ports/Tools/scripts/convert-makefile-header.pl
> ./Makefile converted
> 
> bsam% grep ^# Makefile
> # Created by: Alex Varju <varju at webct.com>
> # $FreeBSD$
> -----

That is how I get doomed. iirc just add an empty line between standards headers
and "specific" one and the tool will not nuked them.

regards,
Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/svn-ports-all/attachments/20130322/3d90a5e0/attachment.sig>