svn commit: r41011 - head/en_US.ISO8859-1/htdocs/cgi

[Chris Rees]

Author: crees (ports committer)
Date: Mon Feb 18 20:56:52 2013
New Revision: 41011
URL: http://svnweb.freebsd.org/changeset/doc/41011

Log:
  Trailing newlines are stripped from any attachments to PRs.  This is a problem
  commonly manifested by distinfo updates, where the file ends up without a
  newline.  Newer versions of GNU patch also choke on such patches.
  
  There is probably a more elegant solution than this, but given that GNATS
  is not going to be with us for too long, we can rely on the behaviour of tools
  to ignore any trailing newlines if they are added incorrectly [patch, shar].
  
  http://lists.freebsd.org/pipermail/svn-ports-all/2013-February/012069.html
  
  Anyone who can show that adding extra newlines to attachments causes breakage
  is welcome to comment.
  
  Bug noticed by:	ak, dougb
  Approved by:	maintainer timeout (shaun, five months, multiple emails)

Modified:
  head/en_US.ISO8859-1/htdocs/cgi/query-pr.cgi

Modified: head/en_US.ISO8859-1/htdocs/cgi/query-pr.cgi
==============================================================================
--- head/en_US.ISO8859-1/htdocs/cgi/query-pr.cgi	Mon Feb 18 19:54:21 2013	(r41010)
+++ head/en_US.ISO8859-1/htdocs/cgi/query-pr.cgi	Mon Feb 18 20:56:52 2013	(r41011)
@@ -198,6 +198,7 @@ sub main
 			$patch->filename;
 
 		print $patch->data;
+		print "\n";
 
 		Exit();
 	}