Error bit using of wPortStatus when need usbd_req_warm_reset_port

[Shichun.Ma at dell.com]

Dell Customer Communication - Confidential

Hi HPS,
Thanks your kindly explanation.
The patch works with my device, please commit to main stream.

Regards,

Horse Ma (Shichun Ma)

Software Engineer
Dell | Cloud client-computing - Wyse
office +86 10 82862579,  Mobile +86 13241851528

See our products at www.dell.com/wyse

-----Original Message-----
From: Hans Petter Selasky <hps at selasky.org> 
Sent: Sunday, March 8, 2020 8:40 PM
To: Ma, Horse; freebsd-usb at freebsd.org
Cc: Hu, Shunchao
Subject: Re: Error bit using of wPortStatus when need usbd_req_warm_reset_port


[EXTERNAL EMAIL] 

On 2020-03-08 12:15, Shichun.Ma at dell.com wrote:
> Link info need 4 bits and they take bit 5 to bit 9, while  UPS_PORT_POWER  takes bit 9.
> So this will give wrong link state info in function uhub_suspend_resume_port when it check if need usbd_req_warm_reset_port.
> Please review and kindly suggest how to fix this issue.

Hi,

You are absolutely right. Good catch.

I think we will just remove the POWER bit from the super speed RH. It is currently not needed for anything. Then the LINK state values won't be clobbered like you found.

Does the attached patch work for you?

--HPS