Error bit using of wPortStatus when need usbd_req_warm_reset_port

[Hans Petter Selasky]

On 2020-03-08 12:15, Shichun.Ma at dell.com wrote:
> Link info need 4 bits and they take bit 5 to bit 9, while  UPS_PORT_POWER  takes bit 9.
> So this will give wrong link state info in function uhub_suspend_resume_port when it check if need usbd_req_warm_reset_port.
> Please review and kindly suggest how to fix this issue.

Hi,

You are absolutely right. Good catch.

I think we will just remove the POWER bit from the super speed RH. It is 
currently not needed for anything. Then the LINK state values won't be 
clobbered like you found.

Does the attached patch work for you?

--HPS
-------------- next part --------------
A non-text attachment was scrubbed...
Name: usb_power.diff
Type: text/x-patch
Size: 1204 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-usb/attachments/20200308/fda4bc9a/attachment.bin>