usb/140810: 8.X+ uftdi copy and paste problem / tty overflow

[Corey Smith]

The following reply was made to PR usb/140810; it has been noted by GNATS.

From: Corey Smith <csmith at bonddesk.com>
To: Hans Petter Selasky <hselasky at c2i.net>
Cc: "freebsd-usb at freebsd.org" <freebsd-usb at freebsd.org>,
	"freebsd-gnats-submit at freebsd.org" <freebsd-gnats-submit at freebsd.org>
Subject: Re: usb/140810: 8.X+ uftdi copy and paste problem / tty overflow
Date: Mon, 23 Nov 2009 17:04:27 -0500

 On Mon, 2009-11-23 at 16:01 -0500, Hans Petter Selasky wrote:
 > Your issue looks like a hardware issue. Does the following patch help?
 > 
 > ==== //depot/projects/usb/src/sys/dev/usb/serial/uftdi.c#16 -
 > src/sys/dev/usb/serial/uftdi.c ====
 > @@ -165,7 +165,7 @@
 >                 .endpoint = UE_ADDR_ANY,
 >                 .direction = UE_DIR_OUT,
 >                 .bufsize = UFTDI_OBUFSIZE,
 > -               .flags = {.pipe_bof = 1,.force_short_xfer = 1,},
 > +               .flags = {.pipe_bof = 1,},
 >                 .callback = &uftdi_write_callback,
 >         },
 > 
 
 Your patch worked.
 
 FWIW: This patch also works:
 
 # diff -u sys/dev/usb/serial/uftdi.c.orig sys/dev/usb/serial/uftdi.c
 --- sys/dev/usb/serial/uftdi.c.orig	2009-11-23 16:48:01.000000000 -0500
 +++ sys/dev/usb/serial/uftdi.c	2009-11-23 17:54:23.000000000 -0500
 @@ -93,7 +93,7 @@
  
  #define	UFTDI_IBUFSIZE 64		/* bytes, maximum number of bytes per
  					 * frame */
 -#define	UFTDI_OBUFSIZE 64		/* bytes, cannot be increased due to
 +#define	UFTDI_OBUFSIZE 63		/* bytes, cannot be increased due to
  					 * do size encoding */
  
  enum {
 
 Is there a way to fix this so USB-16COM-RM will work properly in a -RELEASE again?
 
 -Corey Smith