RELENG_7_1: bce driver change generating too much interrupts ?

[Xin LI]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mike Jakubik wrote:
> On Mon, December 8, 2008 5:22 pm, Mike Jakubik wrote:
>> On Mon, December 8, 2008 5:12 pm, Xin LI wrote:
>>
>>> Which version are you currently using?  My previous commit only fixes
>>> the excessive interrupt issue, I think this could be a different
>>> problem, I'm taking a look at the code to see if I can have something
>>> for you.
>> I was running on the version just prior to the latest interrupt commit. I
>> have now updated to the one with the interrupt fix. Will let you know if
>> things change.
>>
>> Thank You.
> 
> The interrupt rate has decreased significantly, however i am still having
> having problem with applications that hold stateful connections. The rx
> errors are also still showing, i suspect this is related to the problem.
> How can i roll back this driver to the last known good version?

Hi, Mike,

I think they are different problems.  Could you, please, give me
feedback about whether:

 - The old driver does not trigger the problem?

 - The patched driver restore all the old driver behavior?

=============
Rationale for my patch.  To say it simply, it removes "Received L2
packets discarded" value from being counted from ierror.  In the past,
we count the following:

	- Undersize packets
	- Oversized packets
	- Received packets discarded due to lack of controller buffer memory
	- Alignment errors
	- Frame check sequence errors

Now, it counts the following four stuff as well:

	- Received L2 packets discarded ** removed
	- Received packets discarded by rule
	- Received packet FTQ discards
	- Valid packets received but no RX buffers available

I have checked the old FreeBSD driver and the Linux driver, both have
the "Received L2 packets discarded" value increasing every second, so I
don't believe that this is a real problem.  I'll double check with David
to make sure about this.

Cheers,
- --
Xin LI <delphij at delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (FreeBSD)

iEYEARECAAYFAklE2JQACgkQi+vbBBjt66Bl0gCfZ6NVNXpC2ynUZjaZButg+4jo
vgYAnAzE2iFWcZMZ29j3qtpwQ5f0xh9V
=3l8f
-----END PGP SIGNATURE-----
-------------- next part --------------
Index: if_bce.c
===================================================================
--- if_bce.c	(revision 186076)
+++ if_bce.c	(working copy)
@@ -7408,7 +7408,6 @@
 		(u_long) sc->stat_IfInMBUFDiscards +
 		(u_long) sc->stat_Dot3StatsAlignmentErrors +
 		(u_long) sc->stat_Dot3StatsFCSErrors +
-		(u_long) sc->stat_IfInFramesL2FilterDiscards +
 		(u_long) sc->stat_IfInRuleCheckerDiscards +
 		(u_long) sc->stat_IfInFTQDiscards +
 		(u_long) sc->com_no_buffers;