[src] cvs commit: src/sys/cam cam_periph.c

[Poul-Henning Kamp]

In message <20031023133748.GA33994 at melusine.cuivre.fr.eu.org>, Thomas Quinot wr
ites:
>
>--azLHFNyN32YCQGCU
>Content-Type: text/plain; charset=us-ascii
>Content-Disposition: inline
>Content-Transfer-Encoding: quoted-printable
>
>* Poul-Henning Kamp, 2003-10-18 :
>
>>   There is no need to muck about with the B_PHYS flag here.  We never even
>>   get close to DEV_STRATEGY() which is the only place it is relevant.
>>  =20
>>   Revision  Changes    Path
>>   1.54      +0 -8      src/sys/cam/cam_periph.c
>
>I'm afraid this change is wrong.
>
>> -		/* set the flags */
>> -		mapinfo->bp[i]->b_flags =3D B_PHYS;
>> -
>
>12 lines below that point, we call vmapbuf(mapinfo->bp[i]),
>which will panic if B_PHYS is not set. Please consider a backout.

No longer so, I have removed those checks.

I'm only waiting for a review on the vinum bits before B_PHYS
will be entirely gone.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.