[src] cvs commit: src/sys/cam cam_periph.c

Thomas Quinot thomas at FreeBSD.ORG
Thu Oct 23 06:37:52 PDT 2003


* Poul-Henning Kamp, 2003-10-18 :

>   There is no need to muck about with the B_PHYS flag here.  We never even
>   get close to DEV_STRATEGY() which is the only place it is relevant.
>   
>   Revision  Changes    Path
>   1.54      +0 -8      src/sys/cam/cam_periph.c

I'm afraid this change is wrong.

> -		/* set the flags */
> -		mapinfo->bp[i]->b_flags = B_PHYS;
> -

12 lines below that point, we call vmapbuf(mapinfo->bp[i]),
which will panic if B_PHYS is not set. Please consider a backout.

Thomas.

-- 
    Thomas.Quinot at Cuivre.FR.EU.ORG
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-scsi/attachments/20031023/4642673f/attachment.bin


More information about the freebsd-scsi mailing list