grep -Dskip doesn't skip FIFOs

Marco Steinbach coco at executive-computing.de
Thu Dec 6 20:25:41 UTC 2012


David Xu wrote on 06.12.2012 04:46:
> On 2012/12/06 11:28, David Xu wrote:
>> On 2012/12/06 07:07, Marco Steinbach wrote:
>>> Hi there,
>>>
>>> grep(1) does not seem to skip FIFOs when told to.
>>
>> <snip>
>>
>> I think you need a patch to fix it, the bug is in ggrep, it tries to
>> open a FIFO before checking if it is a FIFO, then blocked.
>>
>> http://people.freebsd.org/~davidxu/patch/grep.c.diff
>>
>> _______________________________________________
> 
>>
> 
> or the patch:
> http://people.freebsd.org/~davidxu/patch/grep.c.diff2
> 
> The patch opens file with O_NONBLOCK, then turns off O_NONBLOCK,
> and only checks if a file is a FIFO in reset() function.

This patch also seems to fix it.  I can't comment on the patches 
themselves, though.

Anyway, thank you again for taking care of this.

MfG CoCo


More information about the freebsd-questions mailing list