[Bug 256001] dns/knot3: upgrade to 3.0.6

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256001

Leo Vandewoestijne <freebsd at dns.company> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #225086|0                           |1
        is obsolete|                            |
 Attachment #225123|                            |maintainer-approval+
              Flags|                            |

--- Comment #2 from Leo Vandewoestijne <freebsd at dns.company> ---
Created attachment 225123
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=225123&action=edit
knot 3.0.6 diff

> git diff instead of svn diff
>
I seriously dislike maintaining the ridiculous amounts of dependencies for
simply communicating a few lines of mutations.
So by these neither, but a normal diff.


> Any particular reason for this comments?
>
autoconf is listed as required at the instructions at knot-dns.cz,
but I think it was core maintainer who removed it.
The comment is a reminder of this conflicting information.

For IDN_LIB_DEPENDS counts the exact same.

But PLIST_FILES is likely safe to delete.


Then portlint / portfmt / portclippy have not been very useful to me in the
past, mainly ruining cosmetics to provide a clear overview / disclosing direct
correlation with one thing and another which now need to be listed devided far
away.

But I admit portclippy does provide useful pointers (where portlint left you
clueless).
Still, clearly it's a dangerous one to "fly by the tools":
It isn't always keeping in account things are within an "if" block.
Also I'm not really comfortable using variables before having them defined.
Is it safe to revers the order of these lines?

USERS=          knot
GROUPS=         knot
SUB_LIST+=      USERS="${USERS}" GROUPS="${GROUPS}"    

But for the rest I followed it's instructions as much as possible, and so;
poudriere is happy
portlint is happy
portfmt is happy
portclippy is almost entirely happy, and so am I.

-- 
You are receiving this mail because:
You are the assignee for the bug.