[Bug 256001] dns/knot3: upgrade to 3.0.6

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256001

Nuno Teixeira <eduardo at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eduardo at FreeBSD.org

--- Comment #1 from Nuno Teixeira <eduardo at FreeBSD.org> ---
Hello,

Before I can take this PR could you take a look at:

1. Could you provide a git diff instead of svn diff?
https://docs.freebsd.org/en/books/porters-handbook/upgrading/#git-diff

2. I've found several commented port options in Makefile:
---
#BUILD_DEPENDS= autoconf>=2.65:devel/autoconf \
#               gsed:textproc/gsed
and
#PLIST_FILES=   etc/rc.d/${PORTNAME}

Any particular reason for this comments?

3. `portclippy Makefile`:
---
# PORTNAME block
PORTNAME
DISTVERSION
CATEGORIES
MASTER_SITES
PKGNAMESUFFIX

# Maintainer block
MAINTAINER
COMMENT

# License block
LICENSE
LICENSE_FILE

# Dependencies
BUILD_DEPENDS
LIB_DEPENDS

# USES block
USES
+USE_LDCONFIG
+USE_RC_SUBR

-CONFLICTS

# Configure block
HAS_CONFIGURE

-BINARY_ALIAS

CONFIGURE_ARGS

-USE_RC_SUBR
# Make block
+INSTALL_TARGET

# Conflicts
+CONFLICTS

# Standard bsd.port.mk variables
+BINARY_ALIAS
SUB_FILES
+SUB_LIST

-USE_LDCONFIG

-INSTALL_TARGET

# Users and groups block
USERS
GROUPS

-SUB_LIST

# Packaging list block
PORTDOCS

# Options definitions
OPTIONS_DEFINE

# Options descriptions
DNSTAP_DESC
+FASTPARSER_DESC
+MAXMINDDB_DESC

# Options helpers
+DNSTAP_LIB_DEPENDS
DNSTAP_CONFIGURE_ENABLE
DNSTAP_CONFIGURE_WITH
-DNSTAP_LIB_DEPENDS
DNSTAP_CPPFLAGS
DOCS_CONFIGURE_OFF

-FASTPARSER_DESC
FASTPARSER_CONFIGURE_ENABLE
-IDN_CONFIGURE_WITH
IDN_CONFIGURE_OFF

-MAXMINDDB_DESC

+IDN_CONFIGURE_WITH
MAXMINDDB_LIB_DEPENDS
MAXMINDDB_CONFIGURE_ENABLE
---
You use portclippy to organize Makefile blocks

-- 
You are receiving this mail because:
You are the assignee for the bug.