[Bug 223314] textproc/ripgrep: expose SIMD options

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223314

Jan Beich <jbeich at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #187574|maintainer-approval?(petter |
              Flags|i.valkonen at iki.fi)          |
 Attachment #187574|0                           |1
        is obsolete|                            |
 Attachment #187662|                            |maintainer-approval?(petter
              Flags|                            |i.valkonen at iki.fi)

--- Comment #9 from Jan Beich <jbeich at FreeBSD.org> ---
Created attachment 187662
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=187662&action=edit
v1.1

(In reply to petteri.valkonen from comment #8)
> I'm afraid I'm not familiar enough with Rust's internals to offer
> any meaningful feedback on this patch.

Neither me. I don't use Rust outside of firefox or ripgrep.

Are you going to approve or not? The patch here can land before bug 223342.

> It seems you and John have a good discussion going, though.

The ports framework currently doesn't support depending on specific options in
dependencies, so individual ports work around by managing defaults or using
slaves. For one, databases/sqlite3 has a number of options changing which will
break consumers. textproc/ripgrep depends on PORT_LLVM=off in lang/rust which
is already default, so this is mostly FYI. Besides, PORT_LLVM maybe dropped if
it proves to be hard to maintain such as more Rust features start to depend on
APIs specific to bundled LLVM.

> I'd like to see the RUSTC_BOOTSTRAP=1 hack be better documented in
> the Makefile itself (i.e. why is it needed?), and not just be
> mentioned in passing in the PR.

"# cheat Nightly requirement" wasn't good enough? OK, I've made it more
verbose.

-- 
You are receiving this mail because:
You are the assignee for the bug.