[Bug 182209] [new port] emulators/hyperv-ic: Ports containing Hyper-V integration components for FreeBSD

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=182209

--- Comment #33 from John Marino <marino at FreeBSD.org> ---
Okay, let's go through this methodically then:

X# $FreeBSD$
XUSES+=uidfix

Why is this on line #2?  This is normally much lower in the makefile


XPORTNAME=    hyperv-is
XPORTVERSION=    1.1
XCATEGORIES=    kld
XMASTER_SITES=   
https://github.com/FreeBSDonHyper-V/Hyperv-Ports/raw/hyperv-is-master/BIS-${PORTVERSION}/FreeBSD-${OSREL}/ports/
XMAINTAINER=    bsdic at microsoft.com
XCOMMENT=    FreeBSD Integration Service on Hyper-v 
X
XONLY_FOR_ARCHS=    amd64 i386
X.include <bsd.port.pre.mk>
XFILE_84=    hyperv-is-8.4.${PORTVERSION}${EXTRACT_SUFX}
XFILE_91=    hyperv-is-9.1.${PORTVERSION}${EXTRACT_SUFX}
XFILE_92=    hyperv-is-9.2.${PORTVERSION}${EXTRACT_SUFX}
XFILE_93=    hyperv-is-9.3.${PORTVERSION}${EXTRACT_SUFX}
XFILE_100=    hv-kvp-${PORTVERSION}${EXTRACT_SUFX}
XFETCH_ARGS+=    -Fpr

The FETCH_ARGS line didn't change.  This is the default value, so this line has
no reason to exist.

XCC=clang
XCXX=clang++
XCPP=clang-cpp

So this wasn't addressed either.  How is this even working on FreeBSD 8.4 that
doesn't have clang?   Did you look into USES+= compiler:<option> as I
suggested?  

If nothing else, explain why you are overriding CC/CXX/CPP...


Xpost-extract:
X    @${MKDIR} ${STAGEDIR}/boot 
X    @${MKDIR} ${STAGEDIR}/boot/kernel 
X    @${MKDIR} ${STAGEDIR}/etc/ && ${MKDIR} ${STAGEDIR}/etc/rc.d 
X    @${MKDIR} ${STAGEDIR}/usr/share && ${MKDIR} ${STAGEDIR}/usr/share/man
X    @${MKDIR} ${STAGEDIR}/usr/share/man/man1 && ${MKDIR}
${STAGEDIR}/usr/share/man/man4 && ${MKDIR} ${STAGEDIR}/usr/share/man/man8
X    @${MKDIR} ${STAGEDIR}/usr/local/hyperv && ${MKDIR}
${STAGEDIR}/usr/local/hyperv/scripts
X    @${MKDIR} ${STAGEDIR}/usr/sbin
X.if exists(/boot/loader.conf)
X    @${CP} /boot/loader.conf ${STAGEDIR}/boot/loader.conf.bak
X.else

This line violates filesystem checks.  A port is not supposed to touch /boot



X    @${TOUCH} ${STAGEDIR}/boot/loader.conf.bak 


Here as well

X.endif
X.if exists(/etc/rc.conf)
X    @${CP} /etc/rc.conf ${STAGEDIR}/etc/rc.conf.bak

ditto.
This is also not normal.  sysadmins are suppose to hand-edit rc.conf


The post-(de)install scripts are also touching these files.  This needs to be
justified and frankly I need to get more opinions on what this port is trying
to do to system conf files.

-- 
You are receiving this mail because:
You are the assignee for the bug.