[Bug 182209] [new port] emulators/hyperv-ic: Ports containing Hyper-V integration components for FreeBSD

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=182209

--- Comment #32 from Kylie <kyliel at microsoft.com> ---
(In reply to John Marino from comment #25)
> Hmmm, there are a number of questions I have:
> 
> 
> XPORTNAME=	hyperv-ic
> XPORTVERSION=	1.0
> XCATEGORIES=	kld
> XMASTER_SITES=
> https://github.com/FreeBSDonHyper-V/Hyperv-Ports/raw/packages/hyperv-ic/
> X
> XMAINTAINER=	bsdic at microsoft.com
> XCOMMENT=	Hyper-V Integration Components
> X
> XFETCH_ARGS=	-Fpr
> 
> 
> ^^^^
> What is the purpose of redefining FETCH_ARGS?  I suspect this is unneed
If we use default FETCH_ARGS, sometimes fetch will fail in our test
environment. From this discussion
http://lists.freebsd.org/pipermail/freebsd-ports/2013-December/088717.html, it
seems default value for FETCH_ARGS is "-AFpr" and "-A" is to limit fetch
redirection.  Then could we redefine it to ensure fetch operation successfully?
Thanks. 

> 
> XCC?=clang
> XCXX?=clang++
> XCPP?=clang-cpp
> 
> 
> ^^^^
> This looks very suspicious.
> For one, it won't work on FreeBSD 9 and below
> Secondly, you probably should be using "USES+=compiler:<option>"  (see
> Mk/Uses/compiler.mk for details).
> Is clang truely required and GCC absolutely cannot be used?
> 
CLANG works for our FreeBSD 9.x and 8.x ports. However if we change compiler to
GCC, our KVP daemon ports on FreeBSD10 will have some issue which we need to
investigate.  
>From this wiki https://wiki.freebsd.org/PortsAndClang, it seems Clang is
default compiler on FreeBSD 10. 
Could we keep CLANG as compiler since functions on 10, 9.x and 8.4 are verified
successfully. 

> 
> XONLY_FOR_ARCHS=	amd64 i386
> X
> X.include <bsd.port.pre.mk>
> X
> X.if ${OSVERSION} != 901000
> XBROKEN=	Only for FreeBSD 9.1 Release
> X.endif
> 
> ^^^^
> Am I looking at the wrong shar?  This is limited to FreeBSD 9.1 (And I kind
> of doubt the OSVERSION for 9.1 is exactly 901000 too)
> 
> 
> 
> Xpre-install:
> X	@PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
> 
> remove "@"
> 
> X
> Xpost-install:
> X	@PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
> X
> 
> remove "@"
> 
> 
> Xpost-deinstall:
> X	@PKG_PREFIX=${PREFIX} ${SH} ${PKGDEINSTALL} ${PKGNAME} POST-DEINSTALL
> 
> remove this completely -- it's not necessary anymore (it's don't
> automatically)

I just uploaded "shar file" which adopted these feedbacks. Thanks for valuable
feedbacks again.

-- 
You are receiving this mail because:
You are the assignee for the bug.