ports/150235: sysutils/smartmontools build system bug

[Alex Samorukov]

The following reply was made to PR ports/150235; it has been noted by GNATS.

From: Alex Samorukov <samm at os2.kiev.ua>
To: Doug Barton <dougb at FreeBSD.org>, 
 Garrett Wollman <wollman at FreeBSD.org>,
 bug-followup at FreeBSD.org, developers at FreeBSD.org
Cc:  
Subject: Re: ports/150235: sysutils/smartmontools build system bug
Date: Mon, 06 Sep 2010 00:26:56 +0200

 >
 >> It is not the case. cciss.cpp from the sources uses dev/ciss/cissio.h to
 >> work with cciss devices on FreeBSD. configure script checks if this file
 >> is exists on the compile time, and if its not - does not compile cciss
 >> support in the smartmontools.
 >> If user will try to use cciss driver in this case - smartmontools will
 >> display an error:
 >>
 >> "CCISS support is not available in this build of smartmontools,\n"
 >> "/usr/src/sys/dev/ciss/cissio.h was not available at build time.\n\n");
 >>      
 > If that interface is public (which it seems to be, from glancing at the file),
 > the header should be installed in /usr/include/sys.  There are precedents for
 > this, see<sys/aac_ioctl.h>  and<sys/digiio.h>  (and presumably others).
 >
 > Any reason not to follow Garrett's suggestion to work with a src developer,
 > perhaps one of the ones listed in the header file you need, to have it put
 > somewhere public?
 >    
 
 Just to remind - Garrett's suggestion was to exclude /usr/src/sys from 
 the includes and break ciss functionality completely this way ;-)
 
 Of course i have nothing against cissio.h in the /usr/include/sys and i 
 will try to contact author right now. But before this happens (and also 
 before it will be in all supported freebsd versions) i`m also against 
 removing srv includes from the sources, because it will break ciss 
 functionality only because one person had outdated src tree.
 >   - Philip
 >
 >