ports/150235: sysutils/smartmontools build system bug

[Philip Paeps]

The following reply was made to PR ports/150235; it has been noted by GNATS.

From: Philip Paeps <philip at freebsd.org>
To: Alex Samorukov <samm at os2.kiev.ua>
Cc: Doug Barton <dougb at FreeBSD.org>, Garrett Wollman <wollman at FreeBSD.org>,
	bug-followup at FreeBSD.org, developers at FreeBSD.org
Subject: Re: ports/150235: sysutils/smartmontools build system bug
Date: Mon, 6 Sep 2010 00:22:08 +0200

 On 2010-09-06 00:06:54 (+0200), Alex Samorukov <samm at os2.kiev.ua> wrote:
 > On 09/05/2010 11:44 PM, Doug Barton wrote:
 > > On 09/05/2010 12:28 PM, Alex Samorukov wrote:
 > >> Your proposed patch will break smartmontools functionality - thats why
 > >> i`m not able to accept it.
 > >
 > > It's not at all clear to me why developers@ is cc'ed on these 
 > > messages, but since we are ...
 > >
 > > Alex,
 > >
 > > Can you please explain why the change Garrett is suggesting will break 
 > > anything? According to his PR all the headers that smartmontools needs 
 > > are included in /usr/include. Is that not the case?
 > It is not the case. cciss.cpp from the sources uses dev/ciss/cissio.h to 
 > work with cciss devices on FreeBSD. configure script checks if this file 
 > is exists on the compile time, and if its not - does not compile cciss 
 > support in the smartmontools.
 > If user will try to use cciss driver in this case - smartmontools will 
 > display an error:
 > 
 > "CCISS support is not available in this build of smartmontools,\n"  
 > "/usr/src/sys/dev/ciss/cissio.h was not available at build time.\n\n");
 
 If that interface is public (which it seems to be, from glancing at the file),
 the header should be installed in /usr/include/sys.  There are precedents for
 this, see <sys/aac_ioctl.h> and <sys/digiio.h> (and presumably others).
 
 Any reason not to follow Garrett's suggestion to work with a src developer,
 perhaps one of the ones listed in the header file you need, to have it put
 somewhere public?
 
  - Philip
 
 -- 
 Philip Paeps                                    Please don't Cc me, I am
 philip at freebsd.org                               subscribed to the list.