Bring "netstat -R" to stable10

hiren panchasara hiren at strugglingcoder.info
Mon Apr 6 17:40:59 UTC 2015


On 04/06/15 at 09:36P, Xin Li wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
> 
> On 04/06/15 09:20, hiren panchasara wrote:
> > On 04/02/15 at 01:53P, hiren panchasara wrote:
> >> I want to use netstat -R on stable10 and following 2 commits are
> >> needed to be MFC'd for that: 
> >> https://svnweb.freebsd.org/base?view=revision&revision=266418 
> >> https://svnweb.freebsd.org/base?view=revision&revision=266448
> >> 
> >> r266418 adds a field to 'struct inpcb' but it uses a spare field
> >> so I _think_ it's MFCable and doesn't break KBI/KPI?
> >> 
> >> Can someone please comment if that's not the case?
> > 
> > I'll go commit this today.
> 
> I think you should have asked re@ or this may get otherwise unnoticed...

My bad. That didn't occur to me.
> 
> I was kinda surprised with the fact that the spare fields are defined
> as 'uint' and not something like 'u_int32_t' because the former is
> less defined.  We should probably use u_int32_t instead for the spare
> fields to avoid the ambiguity.

Yeah, that'd be a separate change. 
> 
> However, because all platforms that FreeBSD currently supports have
> 32-bit int (doing a quick grep of __UINT_MAX), I think the change does
> not break KBI.  The added field does not break KPI.

Ok, I'll commit to 10 as is. Appreciate you chiming in.

Cheers,
Hiren
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 618 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-net/attachments/20150406/7298f998/attachment.sig>


More information about the freebsd-net mailing list