Bring "netstat -R" to stable10

Xin Li delphij at delphij.net
Mon Apr 6 16:36:22 UTC 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 04/06/15 09:20, hiren panchasara wrote:
> On 04/02/15 at 01:53P, hiren panchasara wrote:
>> I want to use netstat -R on stable10 and following 2 commits are
>> needed to be MFC'd for that: 
>> https://svnweb.freebsd.org/base?view=revision&revision=266418 
>> https://svnweb.freebsd.org/base?view=revision&revision=266448
>> 
>> r266418 adds a field to 'struct inpcb' but it uses a spare field
>> so I _think_ it's MFCable and doesn't break KBI/KPI?
>> 
>> Can someone please comment if that's not the case?
> 
> I'll go commit this today.

I think you should have asked re@ or this may get otherwise unnoticed...

I was kinda surprised with the fact that the spare fields are defined
as 'uint' and not something like 'u_int32_t' because the former is
less defined.  We should probably use u_int32_t instead for the spare
fields to avoid the ambiguity.

However, because all platforms that FreeBSD currently supports have
32-bit int (doing a quick grep of __UINT_MAX), I think the change does
not break KBI.  The added field does not break KPI.

Cheers,
- -- 
Xin LI <delphij at delphij.net>    https://www.delphij.net/
FreeBSD - The Power to Serve!           Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.1.2 (FreeBSD)

iQIcBAEBCgAGBQJVIrX9AAoJEJW2GBstM+nsqPIQAJbPIm/+CW8M7GYIsi+7uZhB
lmre7YxpRQrYZhIEcpbu7M06v/qCzAqnrIxbddOtvOjSvc606yW5fgQlns30IoD0
BzOpu0Q8tTwYMRq2ccQ02hQoODvMkFPNloTqxe5XXs7Gc+QqVQxehmKZhEIpTSDY
JzMWmJlfthAl5BUx5c9SbrgYCd9XkLYpqGeRD7KbveU5dlVXB/wEsftRH9d7TrRb
Q+Ug6y6nsb0XGF9ayUcsK68EbXSgbxvA3LVummeiRuFuFUcCQ1JqCAIQo13yWckQ
bGk8Bw5a5kXUrRzH/TkGHKqUVxxl7hRunUu4NIHmI8wbjS/qcchFiWgC9B2BO4WX
ri/2UHYJVf4Ll3gefD6MdG07Y46DZCKtEkcmynxW8jtC+eomi7uQundGr7jKshCt
mnT9c/s0lIBwW639QQNEkJOI3/ZZJuU7IjSf7jgbnO0+MD6GS7O4qrxp/yfQxXjJ
lSY6qWuxF4eAzv0DUWYpHHG0BT1payu/ZnFgunPyj5ym1Kadm2nASMJt3nCOmlow
oapz7K1L5nGAPnQf5JHPO2mHIowLoBJbTYU/KtAZ8HSiKBFBG2EcNd0j9Dd11TD8
uTGNvNVo3CFkyUIU/bRDWbFIP/BXk4BRUepgglDVk+eij24bGX4gCyfFgvWQ+/sw
QrAa+rUvIMhaLJL8WuyA
=Btjt
-----END PGP SIGNATURE-----


More information about the freebsd-net mailing list