Fixes to the new pagetable page allocation code.
Randall Stewart
rrs at lakerest.net
Wed May 26 07:32:26 UTC 2010
JC:
It looks good to me too ;-)
R
On May 26, 2010, at 1:30 AM, Neel Natu wrote:
> Hi JC,
>
> On Tue, May 25, 2010 at 10:03 PM, C. Jayachandran
> <c.jayachandran at gmail.com> wrote:
>> The attached patch (also at
>> http://people.freebsd.org/~jchandra/for-review/pmap-alloc-page-fix.diff)
>> has two fixes for the new pagetable page allocation code, one to
>> handle NULL return from the allocating function, and another to call
>> VM_WAIT in cases we can wait. It also removes the variable 'req' left
>> over from an earlier change.
>>
>> Please let me know if you have any comments...
>>
>
> Your patch looks fine.
>
> Checking the value of 'ptdpg' is redundant given that you are passing
> in M_WAITOK. I don't think we expect the allocation to fail now that
> you have added the check for M_WAITOK in zone allocator function.
>
> best
> Neel
>
>> JC.
>>
>
------------------------------
Randall Stewart
803-317-4952 (cell)
More information about the freebsd-mips
mailing list