Fixes to the new pagetable page allocation code.
Neel Natu
neelnatu at gmail.com
Wed May 26 05:30:54 UTC 2010
Hi JC,
On Tue, May 25, 2010 at 10:03 PM, C. Jayachandran
<c.jayachandran at gmail.com> wrote:
> The attached patch (also at
> http://people.freebsd.org/~jchandra/for-review/pmap-alloc-page-fix.diff)
> has two fixes for the new pagetable page allocation code, one to
> handle NULL return from the allocating function, and another to call
> VM_WAIT in cases we can wait. It also removes the variable 'req' left
> over from an earlier change.
>
> Please let me know if you have any comments...
>
Your patch looks fine.
Checking the value of 'ptdpg' is redundant given that you are passing
in M_WAITOK. I don't think we expect the allocation to fail now that
you have added the check for M_WAITOK in zone allocator function.
best
Neel
> JC.
>
More information about the freebsd-mips
mailing list