[CFT] capsicum patches for rtsol(8) and rtsold(8)

[Mark Johnston]

On Fri, Nov 02, 2018 at 11:25:40PM +0000, Bjoern A. Zeeb wrote:
> On 24 Oct 2018, at 19:56, Mark Johnston wrote:
> 
> Hi,
> 
> sorry I lost track on this.

No problem, thanks for testing.

> > Yes, I just uploaded a new version of the patch to
> > https://people.freebsd.org/~markj/patches/rtsold_capsicum.diff and 
> > would
> > appreciate any further testing that you can do.
> 
> The rtsol Makefile does not cleanly apply to my HEAD.

I updated the patch yet again, it should apply this time.  The newest
version requires HEAD as of r340130.

> Also there seems to be an empty .else case in both rtsold and rtsol 
> Makefiles.

Fixed, thanks.

> Also I couldn’t get rtsol to link until I realised that it was rescue 
> which didn’t want to link (-j24 output can be confusing).  I guess 
> with -DSMALL gone and MK_CASPER not turned off for rescue or whatever it 
> is the result is not what we expect?

In other cases (e.g., ping(8)) we simply disable libcasper support for
rescue binaries, so I've done the same here.

> >>> resolvconf -a will only update /etc/resolv.conf if the info in
> >>> /var/run/resolvconf/interfaces/vtnet0 has changed, I believe.  Try
> >>> deleting that file too, and then try running rtsol.
> >>
> >> When I deleted /etc/resolv.conf and then rtsol manually it had
> >> re-appeared.  Unclear to me what was in /var/run; I just wanted to 
> >> point
> >> out the difference in behaviour;  maybe you are right;  I’ll go and
> >> check if deleting in /var/run/ as well makes a difference.
> >
> > I don't observe that behaviour with either the stock or patched
> > rtsol(8): for resolvconf(8) to update /etc/resolv.conf (or re-generate
> > it), something under /var/run/resolvconf/interfaces needs to have
> > changed.  So, in my case, deleting /etc/resolv.conf *and*
> > /var/run/resolvconf/interfaces/re0:slaac will cause resolv.conf to be
> > regenerated once rtsold(8) decides to re-run resolvconf(8), but
> > deleting resolv.conf on its own will not.
> 
> I wonder if that’s a bug (unrelated to yours).  I also noticed that 
> when my nameservers changed /etc/resolv.conf did not always reflect 
> this.