[CFT] capsicum patches for rtsol(8) and rtsold(8)

[Bjoern A. Zeeb]

On 24 Oct 2018, at 19:56, Mark Johnston wrote:

Hi,

sorry I lost track on this.

> Yes, I just uploaded a new version of the patch to
> https://people.freebsd.org/~markj/patches/rtsold_capsicum.diff and 
> would
> appreciate any further testing that you can do.

The rtsol Makefile does not cleanly apply to my HEAD.

Also there seems to be an empty .else case in both rtsold and rtsol 
Makefiles.

Also I couldn’t get rtsol to link until I realised that it was rescue 
which didn’t want to link (-j24 output can be confusing).  I guess 
with -DSMALL gone and MK_CASPER not turned off for rescue or whatever it 
is the result is not what we expect?

Just a few lines for you.

..
   15229                                                                 
     ^
   15230 1 warning generated.
   15231 iscsid_stub.c:1:70: warning: implicit declaration of function 
'main' is invalid in C99 [-Wimplicit-function-declaration]
   15232 int _crunched_iscsid_stub(int argc, char **argv, char 
**envp){return main(argc,argv,envp);}
   15233                                                                 
      ^
   15234 1 warning generated.
   15235 
/tank/users/bz/obj/tank/users/bz/git_bz_experimental_v6only/amd64.amd64/tmp/usr/bin/ld: 
error: undefined symbol: cap_init
   15236 >>> referenced by _$$hide$$ rtsol.lo rtsock.c
   15237 >>>               rtsol.lo:(_$$hide$$ rtsol.lo main)
   15238
   15239 
/tank/users/bz/obj/tank/users/bz/git_bz_experimental_v6only/amd64.amd64/tmp/usr/bin/ld: 
error: undefined symbol: cap_service_open
   15240 >>> referenced by _$$hide$$ rtsol.lo rtsock.c
   15241 >>>               rtsol.lo:(_$$hide$$ rtsol.lo main)
   15242
   15243 
/tank/users/bz/obj/tank/users/bz/git_bz_experimental_v6only/amd64.amd64/tmp/usr/bin/ld: 
error: undefined symbol: cap_service_open
   15244 >>> referenced by _$$hide$$ rtsol.lo rtsock.c
   15245 >>>               rtsol.lo:(_$$hide$$ rtsol.lo main)
   15246
   15247 
/tank/users/bz/obj/tank/users/bz/git_bz_experimental_v6only/amd64.amd64/tmp/usr/bin/ld: 
error: undefined symbol: cap_service_open
   15248 >>> referenced by _$$hide$$ rtsol.lo rtsock.c
   15249 >>>               rtsol.lo:(_$$hide$$ rtsol.lo main)
   15250
   15251 
/tank/users/bz/obj/tank/users/bz/git_bz_experimental_v6only/amd64.amd64/tmp/usr/bin/ld: 
error: undefined symbol: nvlist_create
   15252 >>> referenced by _$$hide$$ rtsol.lo rtsock.c
   15253 >>>               rtsol.lo:(_$$hide$$ rtsol.lo main)
   15254
..


>>> resolvconf -a will only update /etc/resolv.conf if the info in
>>> /var/run/resolvconf/interfaces/vtnet0 has changed, I believe.  Try
>>> deleting that file too, and then try running rtsol.
>>
>> When I deleted /etc/resolv.conf and then rtsol manually it had
>> re-appeared.  Unclear to me what was in /var/run; I just wanted to 
>> point
>> out the difference in behaviour;  maybe you are right;  I’ll go and
>> check if deleting in /var/run/ as well makes a difference.
>
> I don't observe that behaviour with either the stock or patched
> rtsol(8): for resolvconf(8) to update /etc/resolv.conf (or re-generate
> it), something under /var/run/resolvconf/interfaces needs to have
> changed.  So, in my case, deleting /etc/resolv.conf *and*
> /var/run/resolvconf/interfaces/re0:slaac will cause resolv.conf to be
> regenerated once rtsold(8) decides to re-run resolvconf(8), but
> deleting resolv.conf on its own will not.

I wonder if that’s a bug (unrelated to yours).  I also noticed that 
when my nameservers changed /etc/resolv.conf did not always reflect 
this.

/bz